This is an automated email from the ASF dual-hosted git repository. suddjian pushed a commit to branch fix-cypress-dom-ref in repository https://gitbox.apache.org/repos/asf/superset.git
commit d519759491f37deb2decb0ba2647f88d53ea3903 Author: David Aaron Suddjian <[email protected]> AuthorDate: Fri Mar 26 14:24:55 2021 -0700 fix(cypress): avoid referencing detached dom nodes --- .../cypress-base/cypress/integration/dashboard/dashboard.helper.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/superset-frontend/cypress-base/cypress/integration/dashboard/dashboard.helper.ts b/superset-frontend/cypress-base/cypress/integration/dashboard/dashboard.helper.ts index 459c943..123c777 100644 --- a/superset-frontend/cypress-base/cypress/integration/dashboard/dashboard.helper.ts +++ b/superset-frontend/cypress-base/cypress/integration/dashboard/dashboard.helper.ts @@ -56,8 +56,9 @@ export function waitForChartLoad(chart: ChartSpec) { return ( cy // this id only becomes visible when the chart is loaded - .wrap(gridComponent) - .find(`#chart-id-${chartId}`, { timeout: 30000 }) + .get(`[data-test="chart-grid-component"] #chart-id-${chartId}`, { + timeout: 30000, + }) .should('be.visible') // return the chart grid component .then(() => gridComponent)
