This is an automated email from the ASF dual-hosted git repository.
hugh pushed a commit to branch hugh/move-ctas-cvas-fields
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/hugh/move-ctas-cvas-fields by
this push:
new 8251f90 fix 1st test
8251f90 is described below
commit 8251f90abf8c8b80bb4e43bf5ef58a477e47a0da
Author: hughhhh <[email protected]>
AuthorDate: Tue Mar 30 18:46:02 2021 -0400
fix 1st test
---
.../javascripts/views/CRUD/data/database/DatabaseModal_spec.jsx | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git
a/superset-frontend/spec/javascripts/views/CRUD/data/database/DatabaseModal_spec.jsx
b/superset-frontend/spec/javascripts/views/CRUD/data/database/DatabaseModal_spec.jsx
index 78427c4..affdea0 100644
---
a/superset-frontend/spec/javascripts/views/CRUD/data/database/DatabaseModal_spec.jsx
+++
b/superset-frontend/spec/javascripts/views/CRUD/data/database/DatabaseModal_spec.jsx
@@ -152,7 +152,7 @@ describe('DatabaseModal', () => {
expect(schemaField).not.toHaveClass('open');
});
});
- it('renders solely "Expose in SQL Lab" option when unchecked', () => {
+ it('renders all settings when "Expose in SQL Lab" is checked', () => {
render(
<ThemeProvider theme={supersetTheme}>
<Provider store={store}>
@@ -181,10 +181,12 @@ describe('DatabaseModal', () => {
// While unchecked, only "Expose in SQL Lab" should display
expect(exposeInSqlLab).toBeChecked();
- const checkboxes = screen.getAllByRole('checkbox');
+ const checkboxes = screen
+ .getAllByRole('checkbox')
+ .filter(checkbox => !checkbox.checked);
// While checked make sure all checkboxes are showing
- expect(checkboxes.length).toEqual(5);
+ expect(checkboxes.length).toEqual(4);
});
it('renders the schema field when allowCTAS is checked', () => {
