This is an automated email from the ASF dual-hosted git repository.

erikrit pushed a commit to branch revert-13694-datasetTableSelector
in repository https://gitbox.apache.org/repos/asf/superset.git

commit 6ad28ef7559d01a31c1574d63ac1d5d098b26f8f
Author: Erik Ritter <[email protected]>
AuthorDate: Wed Mar 31 17:40:01 2021 -0700

    Revert "fix: select table overlay (#13694)"
    
    This reverts commit b247279ffed4660bdbc6d66cd6a44e0104bc253f.
---
 superset-frontend/src/components/DatabaseSelector/index.tsx | 1 -
 superset-frontend/src/components/TableSelector/index.tsx    | 1 -
 2 files changed, 2 deletions(-)

diff --git a/superset-frontend/src/components/DatabaseSelector/index.tsx 
b/superset-frontend/src/components/DatabaseSelector/index.tsx
index 34060bc..75103aa 100644
--- a/superset-frontend/src/components/DatabaseSelector/index.tsx
+++ b/superset-frontend/src/components/DatabaseSelector/index.tsx
@@ -245,7 +245,6 @@ export default function DatabaseSelector({
         placeholder={t('Select a database')}
         autoSelect
         isDisabled={!isDatabaseSelectEnabled || readOnly}
-        menuPosition="fixed"
       />,
       null,
     );
diff --git a/superset-frontend/src/components/TableSelector/index.tsx 
b/superset-frontend/src/components/TableSelector/index.tsx
index 09f5a3a..f6f4020 100644
--- a/superset-frontend/src/components/TableSelector/index.tsx
+++ b/superset-frontend/src/components/TableSelector/index.tsx
@@ -326,7 +326,6 @@ const TableSelector: FunctionComponent<TableSelectorProps> 
= ({
           optionRenderer={renderTableOption}
           valueRenderer={renderTableOption}
           isDisabled={readOnly}
-          menuPosition="fixed"
         />
       );
     } else if (formMode) {

Reply via email to