This is an automated email from the ASF dual-hosted git repository.
hugh pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/master by this push:
new 4187d9e fix: adjusted tab height (#13822)
4187d9e is described below
commit 4187d9e4c4f3e281c3d8021010b9836cd8da12bc
Author: AAfghahi <[email protected]>
AuthorDate: Fri Apr 2 12:44:45 2021 -0400
fix: adjusted tab height (#13822)
---
superset-frontend/src/SqlLab/components/SouthPane/SouthPane.tsx | 3 +--
superset-frontend/src/SqlLab/main.less | 2 +-
superset-frontend/src/components/ProgressBar/index.tsx | 5 +++++
3 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/superset-frontend/src/SqlLab/components/SouthPane/SouthPane.tsx
b/superset-frontend/src/SqlLab/components/SouthPane/SouthPane.tsx
index 10d9aca..5585a15 100644
--- a/superset-frontend/src/SqlLab/components/SouthPane/SouthPane.tsx
+++ b/superset-frontend/src/SqlLab/components/SouthPane/SouthPane.tsx
@@ -33,7 +33,7 @@ import {
LOCALSTORAGE_MAX_QUERY_AGE_MS,
} from '../../constants';
-const TAB_HEIGHT = 64;
+const TAB_HEIGHT = 90;
/*
editorQueries are queries executed by users passed from SqlEditor component
@@ -63,7 +63,6 @@ const StyledPane = styled.div`
flex-direction: column;
}
.tab-content {
- overflow: hidden;
.alert {
margin-top: ${({ theme }) => theme.gridUnit * 2}px;
}
diff --git a/superset-frontend/src/SqlLab/main.less
b/superset-frontend/src/SqlLab/main.less
index 4bb4507..6600ff6 100644
--- a/superset-frontend/src/SqlLab/main.less
+++ b/superset-frontend/src/SqlLab/main.less
@@ -56,7 +56,7 @@ body {
position: relative;
background-color: @lightest;
overflow-x: auto;
- overflow-y: hidden;
+ overflow-y: auto;
> .ant-tabs-tabpane {
position: absolute;
diff --git a/superset-frontend/src/components/ProgressBar/index.tsx
b/superset-frontend/src/components/ProgressBar/index.tsx
index d8f9b1e..93b4315 100644
--- a/superset-frontend/src/components/ProgressBar/index.tsx
+++ b/superset-frontend/src/components/ProgressBar/index.tsx
@@ -30,6 +30,10 @@ const ProgressBar = styled(({ striped, ...props }:
ProgressBarProps) => (
<AntdProgress {...props} />
))`
line-height: 0;
+ position: static;
+ .ant-progress-inner {
+ position: static;
+ }
.ant-progress-outer {
${({ percent }) => !percent && `display: none;`}
}
@@ -37,6 +41,7 @@ const ProgressBar = styled(({ striped, ...props }:
ProgressBarProps) => (
font-size: ${({ theme }) => theme.typography.sizes.s}px;
}
.ant-progress-bg {
+ position: static;
${({ striped }) =>
striped &&
`