This is an automated email from the ASF dual-hosted git repository.

hugh pushed a commit to branch hugh/fix-overwrite
in repository https://gitbox.apache.org/repos/asf/superset.git

commit 58874b4d0648d4092ed3153625860d0b61a1e58d
Author: hughhhh <[email protected]>
AuthorDate: Fri Apr 2 17:42:43 2021 -0400

    hopefully this works
---
 superset/datasets/api.py | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/superset/datasets/api.py b/superset/datasets/api.py
index 72a4ff6..8a8596c 100644
--- a/superset/datasets/api.py
+++ b/superset/datasets/api.py
@@ -29,9 +29,10 @@ from flask_appbuilder.models.sqla.interface import 
SQLAInterface
 from flask_babel import ngettext
 from marshmallow import ValidationError
 
-from superset import event_logger, is_feature_enabled
+from superset import event_logger, is_feature_enabled, db
 from superset.commands.exceptions import CommandInvalidError
 from superset.commands.importers.v1.utils import get_contents_from_bundle
+from superset.connectors.connector_registry import ConnectorRegistry
 from superset.connectors.sqla.models import SqlaTable
 from superset.constants import MODEL_API_RW_METHOD_PERMISSION_MAP, RouteMethod
 from superset.databases.filters import DatabaseFilter
@@ -314,6 +315,14 @@ class DatasetRestApi(BaseSupersetModelRestApi):
             changed_model = UpdateDatasetCommand(
                 g.user, pk, item, override_columns
             ).run()
+            if override_columns:
+              print(5 * '*')
+              print(item)
+              print(5 * '*')
+              datasource = ConnectorRegistry.get_datasource(
+                'table', item['database_id'], db.session
+              )
+              external_metadata = datasource.external_metadata()
             response = self.response(200, id=changed_model.id, result=item)
         except DatasetNotFoundError:
             response = self.response_404()

Reply via email to