This is an automated email from the ASF dual-hosted git repository. hugh pushed a commit to branch hugh/remove-logger-exc in repository https://gitbox.apache.org/repos/asf/superset.git
commit 5738c6609cf649ced2a239993154f75b235cb323 Author: hughhhh <[email protected]> AuthorDate: Mon Apr 12 16:43:48 2021 -0400 figured out --- superset/views/base.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/superset/views/base.py b/superset/views/base.py index fbd1be7..44e8224 100644 --- a/superset/views/base.py +++ b/superset/views/base.py @@ -167,8 +167,6 @@ def api(f: Callable[..., FlaskResponse]) -> Callable[..., FlaskResponse]: def wraps(self: "BaseSupersetView", *args: Any, **kwargs: Any) -> FlaskResponse: try: return f(self, *args, **kwargs) - except SupersetException as ex: - return json_error_response(get_error_msg(), status=ex.status) except NoAuthorizationError as ex: # pylint: disable=broad-except logger.warning(ex) return json_error_response(get_error_msg(), status=401) @@ -200,7 +198,8 @@ def handle_api_exception( logger.warning(ex) return json_errors_response(errors=[ex.error], status=ex.status) except SupersetException as ex: - logger.exception(ex) + if ex.status > 500: + logger.exception(ex) return json_error_response( utils.error_msg_from_exception(ex), status=ex.status )
