This is an automated email from the ASF dual-hosted git repository.

hugh pushed a commit to branch hugh/text-db-config
in repository https://gitbox.apache.org/repos/asf/superset.git

commit 1e58133282464311da96251c8b9ea850a26562d4
Author: hughhhh <[email protected]>
AuthorDate: Tue Apr 13 12:48:38 2021 -0400

    yea
---
 CONTRIBUTING.md |  5 +++++
 Makefile        | 14 +++++++++-----
 2 files changed, 14 insertions(+), 5 deletions(-)

diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index 40818ab..3a979c9 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -442,6 +442,11 @@ superset load-examples
 # Note that your page may not have css at this point.
 # See instructions below how to build the front-end assets.
 FLASK_ENV=development superset run -p 8088 --with-threads --reload --debugger
+
+Or you can install via our Makefile
+
+```bash
+make install
 ```
 
 **Note: the FLASK_APP env var should not need to be set, as it's currently 
controlled
diff --git a/Makefile b/Makefile
index 2da12c8..e3f4c29 100644
--- a/Makefile
+++ b/Makefile
@@ -1,9 +1,8 @@
-# This is the default target, which will be built when 
+# This is the default target, which will be built when
 # you invoke make
 .PHONY: all
-all: install
+all:
 
-# This rule tells make how to build hello from hello.cpp
 install:
        # Install external dependencies
        pip install -r requirements/local.txt
@@ -22,8 +21,13 @@ install:
 
        # Load some data to play with
        superset load-examples
-    
+
 venv:
        # Create a virtual environment and activate it (recommended)
        python3 -m venv venv # setup a python3 virtualenv
-       source venv/bin/activate
\ No newline at end of file
+       source venv/bin/activate
+
+pre-commit:
+       # setup pre commit dependencies
+       pip3 install -r requirements/integration.txt
+       pre-commit install

Reply via email to