This is an automated email from the ASF dual-hosted git repository.

amitmiran pushed a commit to branch 1.2
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/1.2 by this push:
     new 8c73f4e  fix(sqla): timeseries limit not applied when using columns 
(#14297)
8c73f4e is described below

commit 8c73f4e0cd370c43f83067893120194fdafe5fb8
Author: Ville Brofeldt <[email protected]>
AuthorDate: Thu Apr 22 10:38:28 2021 +0300

    fix(sqla): timeseries limit not applied when using columns (#14297)
    
    (cherry picked from commit c760030b839591c6913a8cf1243e822f4b328c98)
---
 superset/connectors/sqla/models.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/superset/connectors/sqla/models.py 
b/superset/connectors/sqla/models.py
index 1d3d5f8..a4a1547 100644
--- a/superset/connectors/sqla/models.py
+++ b/superset/connectors/sqla/models.py
@@ -1278,7 +1278,7 @@ class SqlaTable(  # pylint: 
disable=too-many-public-methods,too-many-instance-at
             is_timeseries  # pylint: disable=too-many-boolean-expressions
             and timeseries_limit
             and not time_groupby_inline
-            and groupby
+            and groupby_exprs_sans_timestamp
         ):
             if db_engine_spec.allows_joins:
                 # some sql dialects require for order by expressions

Reply via email to