This is an automated email from the ASF dual-hosted git repository.

villebro pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 1c16261  fix(native-filters): always show filters without dataset 
(#14409)
1c16261 is described below

commit 1c1626165124ec3a17acf79b1558d86d206d7466
Author: Ville Brofeldt <[email protected]>
AuthorDate: Thu Apr 29 14:25:39 2021 +0300

    fix(native-filters): always show filters without dataset (#14409)
---
 .../FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx          | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git 
a/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx
 
b/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx
index a1226a3..511890b 100644
--- 
a/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx
+++ 
b/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx
@@ -433,7 +433,7 @@ export const FiltersConfigForm: 
React.FC<FiltersConfigFormProps> = ({
           data-test="default-input"
           label={<StyledLabel>{t('Default Value')}</StyledLabel>}
         >
-          {!isDataDirty && (hasFilledDataset || !hasDataset) && (
+          {(!hasDataset || (!isDataDirty && hasFilledDataset)) && (
             <DefaultValue
               setDataMask={({ filterState }) => {
                 setNativeFilterFieldValues(form, filterId, {

Reply via email to