This is an automated email from the ASF dual-hosted git repository. amitmiran pushed a commit to branch 1.2 in repository https://gitbox.apache.org/repos/asf/superset.git
commit b7cffddf5787cb507cb0b23fbbe2cc631bf65408 Author: Ville Brofeldt <[email protected]> AuthorDate: Wed Apr 28 11:41:22 2021 +0300 fix(native-filters): force update control value on change (#14385) * fix(native-filters): force update control value on change * fix test (cherry picked from commit 43ee52be57e06d4277bf07c852c58b6c8dea30db) --- .../FiltersConfigModal/FiltersConfigForm/ControlItems.test.tsx | 2 +- .../nativeFilters/FiltersConfigModal/FiltersConfigForm/ControlItems.tsx | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/ControlItems.test.tsx b/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/ControlItems.test.tsx index 5232a69..04cfe50 100644 --- a/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/ControlItems.test.tsx +++ b/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/ControlItems.test.tsx @@ -123,6 +123,6 @@ test('Clickin on checkbox when resetConfig:flase', () => { expect(props.forceUpdate).not.toBeCalled(); expect(setNativeFilterFieldValues).not.toBeCalled(); userEvent.click(screen.getByRole('checkbox')); - expect(props.forceUpdate).not.toBeCalled(); + expect(props.forceUpdate).toBeCalled(); expect(setNativeFilterFieldValues).not.toBeCalled(); }); diff --git a/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/ControlItems.tsx b/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/ControlItems.tsx index 48c074c..4310a5b 100644 --- a/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/ControlItems.tsx +++ b/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/ControlItems.tsx @@ -72,6 +72,7 @@ const ControlItems: FC<ControlItemsProps> = ({ <Checkbox onChange={() => { if (!controlItem.config.resetConfig) { + forceUpdate(); return; } setNativeFilterFieldValues(form, filterId, {
