This is an automated email from the ASF dual-hosted git repository. rusackas pushed a commit to branch control-section-touchups in repository https://gitbox.apache.org/repos/asf/superset.git
commit 994b9c82e1f5af1e85cdfbd52a3f37f75c5a879a Author: Evan Rusackas <[email protected]> AuthorDate: Sun Nov 15 20:35:33 2020 -0800 simplifying tabOverride logic --- superset-frontend/src/explore/controlPanels/sections.tsx | 1 - superset-frontend/src/explore/controls.jsx | 3 ++- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/superset-frontend/src/explore/controlPanels/sections.tsx b/superset-frontend/src/explore/controlPanels/sections.tsx index c86acbb..21d369e 100644 --- a/superset-frontend/src/explore/controlPanels/sections.tsx +++ b/superset-frontend/src/explore/controlPanels/sections.tsx @@ -101,7 +101,6 @@ export const annotations: ControlPanelSectionConfig = { default: [], description: 'Annotation layers', renderTrigger: true, - tabOverride: 'data', }, }, ], diff --git a/superset-frontend/src/explore/controls.jsx b/superset-frontend/src/explore/controls.jsx index 451ca52..22ae582 100644 --- a/superset-frontend/src/explore/controls.jsx +++ b/superset-frontend/src/explore/controls.jsx @@ -49,7 +49,8 @@ show a warning based on the value of another component. It's also possible to bind arbitrary data from the redux store to the component this way. * - tabOverride: set to 'data' if you want to force a renderTrigger to show up on the `Data` - tab, otherwise `renderTrigger: true` components will show up on the `Style` tab. + tab, or 'customize' if you want it to show up on that tam. Otherwise sections with ALL + `renderTrigger: true` components will show up on the `Customize` tab. * * Note that the keys defined in controls in this file that are not listed above represent * props specific for the React component defined as `type`. Also note that this module work
