This is an automated email from the ASF dual-hosted git repository.
yongjiezhao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/master by this push:
new d71b8b3 Revert "fix(dashboard): multiple query trigger when native
filter enabled (#14734)" (#14762)
d71b8b3 is described below
commit d71b8b38d6f24076a7ab156678aafd79b0a5524d
Author: Yongjie Zhao <[email protected]>
AuthorDate: Sat May 22 08:11:58 2021 +0100
Revert "fix(dashboard): multiple query trigger when native filter enabled
(#14734)" (#14762)
This reverts commit 88de4109e718b7ebeb6b5c51ca14a2fad4299895.
---
.../src/dashboard/components/nativeFilters/FilterBar/state.ts | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git
a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/state.ts
b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/state.ts
index 73c01dd..8edf714 100644
---
a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/state.ts
+++
b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/state.ts
@@ -107,7 +107,10 @@ export const useInitialization = () => {
const numberOfLoadedCharts = Object.values(charts).filter(
({ chartStatus }) => chartStatus !== 'loading',
).length;
- if (numberOfLoadedCharts >= numberOfLoadingCharts) {
+ if (
+ numberOfLoadingCharts > 0 &&
+ numberOfLoadedCharts >= numberOfLoadingCharts
+ ) {
setIsInitialized(true);
}
}, [charts, isInitialized, numberOfLoadingCharts]);