This is an automated email from the ASF dual-hosted git repository. hugh pushed a commit to branch pexdax/enable-connect in repository https://gitbox.apache.org/repos/asf/superset.git
commit a627c3019dd1d5db1399010d27ea3fb6109707ad Author: hughhhh <[email protected]> AuthorDate: Fri Jun 4 12:09:08 2021 -0400 add database name to disableSave --- superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx | 1 + 1 file changed, 1 insertion(+) diff --git a/superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx b/superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx index 6391566..9008049 100644 --- a/superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx +++ b/superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx @@ -360,6 +360,7 @@ const DatabaseModal: FunctionComponent<DatabaseModalProps> = ({ ? !(db?.database_name?.trim() && db?.sqlalchemy_uri) : // disable the button if there is no dbModel.parameters or if // any required fields are falsy + !db?.database_name?.trim() || !dbModel?.parameters || !!dbModel.parameters.required.filter(field => FALSY_FORM_VALUES.includes(db?.parameters?.[field]),
