This is an automated email from the ASF dual-hosted git repository. hugh pushed a commit to branch hugh/db-connection-ui-r2 in repository https://gitbox.apache.org/repos/asf/superset.git
commit 6c04e9af57680b01ee09e8aa1a7b3a0415823962 Author: hughhhh <[email protected]> AuthorDate: Thu Jun 17 11:05:51 2021 -0400 remove schema check on validation --- superset/databases/schemas.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/superset/databases/schemas.py b/superset/databases/schemas.py index 88a849d..946a179 100644 --- a/superset/databases/schemas.py +++ b/superset/databases/schemas.py @@ -353,9 +353,10 @@ class DatabaseValidateParametersSchema(Schema): """ Validate the DB engine spec specific parameters schema. """ - # TODO (aafghahi): use a single parameter - engine_spec = get_engine_spec(data.get("engine") or data.get("backend")) - engine_spec.parameters_schema.load(data["parameters"]) # type: ignore + # TODO (aafghahi): Move this onCreate instead of validation + # engine_spec = get_engine_spec(data.get("engine") or data.get("backend")) + # engine_spec.parameters_schema.load(data["parameters"]) # type: ignore + return None class DatabasePostSchema(Schema, DatabaseParametersSchemaMixin):
