[superset] branch master updated: refactor: icon to icons in erroralert component (#15341)

[pkdotson]

This is an automated email from the ASF dual-hosted git repository.

pkdotson pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/master by this push:
     new a3f4e4a  refactor: icon to icons in erroralert component (#15341)
a3f4e4a is described below

commit a3f4e4ad9e72a6f7d687d495e255fdd0622ca044
Author: Phillip Kelley-Dotson <pkelleydot...@yahoo.com>
AuthorDate: Thu Jun 24 18:05:22 2021 -0700

    refactor: icon to icons in erroralert component (#15341)
    
    * initial commit
    
    * initial commit
    
    * lint
---
 .../components/ErrorMessage/ErrorAlert.test.tsx    | 14 +++------
 .../src/components/ErrorMessage/ErrorAlert.tsx     | 34 +++++++++++++++-------
 2 files changed, 27 insertions(+), 21 deletions(-)

diff --git a/superset-frontend/src/components/ErrorMessage/ErrorAlert.test.tsx 
b/superset-frontend/src/components/ErrorMessage/ErrorAlert.test.tsx
index f9c54e9..bcf80f6 100644
--- a/superset-frontend/src/components/ErrorMessage/ErrorAlert.test.tsx
+++ b/superset-frontend/src/components/ErrorMessage/ErrorAlert.test.tsx
@@ -47,11 +47,9 @@ test('should render', () => {
 
 test('should render warning icon', () => {
   render(<ErrorAlert {...mockedProps} />);
-  expect(screen.getByTestId('icon')).toBeInTheDocument();
-  expect(screen.getByTestId('icon')).toHaveAttribute(
-    'data-name',
-    'warning-solid',
-  );
+  expect(
+    screen.getByRole('img', { name: 'warning-solid' }),
+  ).toBeInTheDocument();
 });
 
 test('should render error icon', () => {
@@ -60,11 +58,7 @@ test('should render error icon', () => {
     level: 'error' as ErrorLevel,
   };
   render(<ErrorAlert {...errorProps} />);
-  expect(screen.getByTestId('icon')).toBeInTheDocument();
-  expect(screen.getByTestId('icon')).toHaveAttribute(
-    'data-name',
-    'error-solid',
-  );
+  expect(screen.getByRole('img', { name: 'error-solid' })).toBeInTheDocument();
 });
 
 test('should render the error title', () => {
diff --git a/superset-frontend/src/components/ErrorMessage/ErrorAlert.tsx 
b/superset-frontend/src/components/ErrorMessage/ErrorAlert.tsx
index bd5ec4c..3298fcf 100644
--- a/superset-frontend/src/components/ErrorMessage/ErrorAlert.tsx
+++ b/superset-frontend/src/components/ErrorMessage/ErrorAlert.tsx
@@ -22,7 +22,7 @@ import { noOp } from 'src/utils/common';
 import Modal from 'src/components/Modal';
 import Button from 'src/components/Button';
 
-import Icon from '../Icon';
+import Icons from 'src/components/Icons';
 import { ErrorLevel, ErrorSource } from './types';
 import CopyToClipboard from '../CopyToClipboard';
 
@@ -106,11 +106,17 @@ export default function ErrorAlert({
     <ErrorAlertDiv level={level} role="alert">
       <div className="top-row">
         <LeftSideContent>
-          <Icon
-            className="icon"
-            name={level === 'error' ? 'error-solid' : 'warning-solid'}
-            color={supersetTheme.colors[level].base}
-          />
+          {level === 'error' ? (
+            <Icons.ErrorSolid
+              className="icon"
+              iconColor={supersetTheme.colors[level].base}
+            />
+          ) : (
+            <Icons.WarningSolid
+              className="icon"
+              iconColor={supersetTheme.colors[level].base}
+            />
+          )}
           <strong>{title}</strong>
         </LeftSideContent>
         {!isExpandable && (
@@ -163,11 +169,17 @@ export default function ErrorAlert({
           onHide={() => setIsModalOpen(false)}
           title={
             <div className="header">
-              <Icon
-                className="icon"
-                name={level === 'error' ? 'error-solid' : 'warning-solid'}
-                color={supersetTheme.colors[level].base}
-              />
+              {level === 'error' ? (
+                <Icons.ErrorSolid
+                  className="icon"
+                  iconColor={supersetTheme.colors[level].base}
+                />
+              ) : (
+                <Icons.WarningSolid
+                  className="icon"
+                  iconColor={supersetTheme.colors[level].base}
+                />
+              )}
               <div className="title">{title}</div>
             </div>
           }