This is an automated email from the ASF dual-hosted git repository. hugh pushed a commit to branch hugh/fix-db-conn-bugs in repository https://gitbox.apache.org/repos/asf/superset.git
commit f40c5979485d530e19ad3f6214b5c58edf625497 Author: hughhhh <hughmi...@gmail.com> AuthorDate: Tue Jun 29 11:48:35 2021 -0700 Fixing SQLA error messaging --- .../src/views/CRUD/data/database/DatabaseModal/index.tsx | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx b/superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx index 909cf0a..11a2f3e 100644 --- a/superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx +++ b/superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx @@ -450,7 +450,7 @@ const DatabaseModal: FunctionComponent<DatabaseModalProps> = ({ const result = await updateResource( db.id as number, dbToUpdate as DatabaseObject, - true, + dbToUpdate.configuration_method === CONFIGURATION_METHOD.DYNAMIC_FORM, // onShow toast on SQLA Forms ); if (result) { if (onDatabaseAdd) { @@ -473,7 +473,10 @@ const DatabaseModal: FunctionComponent<DatabaseModalProps> = ({ }); } setLoading(true); - const dbId = await createResource(dbToUpdate as DatabaseObject, true); + const dbId = await createResource( + dbToUpdate as DatabaseObject, + dbToUpdate.configuration_method === CONFIGURATION_METHOD.DYNAMIC_FORM, // onShow toast on SQLA Forms + ); if (dbId) { setHasConnectedDb(true); if (onDatabaseAdd) {