This is an automated email from the ASF dual-hosted git repository. hugh pushed a commit to branch hugh/fix-step3 in repository https://gitbox.apache.org/repos/asf/superset.git
commit 2135e48a78f956064ce784bbf04c95ca5bbb50e4 Author: hughhhh <[email protected]> AuthorDate: Thu Jul 1 14:37:24 2021 -0400 send parameters if they are available --- .../src/views/CRUD/data/database/DatabaseModal/index.tsx | 3 +-- superset/databases/api.py | 5 +++++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx b/superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx index 411b72d..e83dc69 100644 --- a/superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx +++ b/superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx @@ -180,7 +180,6 @@ function dbReducer( ...(state || {}), }; let query = ''; - switch (action.type) { case ActionType.extraEditorChange: return { @@ -648,7 +647,7 @@ const DatabaseModal: FunctionComponent<DatabaseModalProps> = ({ <StyledFooterButton key="submit" buttonStyle="primary" - onClick={onClose} + onClick={onSave} data-test="modal-confirm-button" > Finish diff --git a/superset/databases/api.py b/superset/databases/api.py index a0689f4..8e6219f 100644 --- a/superset/databases/api.py +++ b/superset/databases/api.py @@ -246,6 +246,11 @@ class DatabaseRestApi(BaseSupersetModelRestApi): new_model = CreateDatabaseCommand(g.user, item).run() # Return censored version for sqlalchemy URI item["sqlalchemy_uri"] = new_model.sqlalchemy_uri + + # If parameters are available return them in the payload + if new_model.parameters: + item["parameters"] = new_model.parameters + return self.response(201, id=new_model.id, result=item) except DatabaseInvalidError as ex: return self.response_422(message=ex.normalized_messages())
