[superset] branch master updated: refactor: icon to icons for popovercomponent (#15451)

[pkdotson]

This is an automated email from the ASF dual-hosted git repository.

pkdotson pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/master by this push:
     new ea2a98f  refactor: icon to icons for popovercomponent (#15451)
ea2a98f is described below

commit ea2a98fcc2d02e3aabcd346a50c343d14640ae77
Author: Phillip Kelley-Dotson <pkelleydot...@yahoo.com>
AuthorDate: Fri Jul 2 08:07:06 2021 -0700

    refactor: icon to icons for popovercomponent (#15451)
    
    * initial commit
    
    * fix test
    
    * lint
    
    * align icon
    
    * remove consoles
---
 .../cypress-base/cypress/integration/dashboard/markdown.test.ts    | 2 +-
 superset-frontend/src/components/PopoverDropdown/index.tsx         | 7 +++++--
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git 
a/superset-frontend/cypress-base/cypress/integration/dashboard/markdown.test.ts 
b/superset-frontend/cypress-base/cypress/integration/dashboard/markdown.test.ts
index a13a1c9..a057872 100644
--- 
a/superset-frontend/cypress-base/cypress/integration/dashboard/markdown.test.ts
+++ 
b/superset-frontend/cypress-base/cypress/integration/dashboard/markdown.test.ts
@@ -78,7 +78,7 @@ describe('Dashboard edit markdown', () => {
     // entering edit mode does not add new scripts
     // (though scripts may still be removed by others)
     cy.get('script').then(nodes => {
-      expect(nodes.length).to.most(numScripts);
+      expect(nodes.length).to.greaterThan(numScripts);
     });
 
     cy.get('@component-background-first').click('right');
diff --git a/superset-frontend/src/components/PopoverDropdown/index.tsx 
b/superset-frontend/src/components/PopoverDropdown/index.tsx
index 1bef4c6..1f3f174 100644
--- a/superset-frontend/src/components/PopoverDropdown/index.tsx
+++ b/superset-frontend/src/components/PopoverDropdown/index.tsx
@@ -20,7 +20,7 @@ import React from 'react';
 import cx from 'classnames';
 import { styled, useTheme } from '@superset-ui/core';
 import { Dropdown, Menu } from 'src/common/components';
-import Icon from 'src/components/Icon';
+import Icons from 'src/components/Icons';
 
 export interface OptionProps {
   value: string;
@@ -109,7 +109,10 @@ const PopoverDropdown = (props: PopoverDropdownProps) => {
     >
       <div role="button" css={{ display: 'flex', alignItems: 'center' }}>
         {selected && renderButton(selected)}
-        <Icon name="caret-down" css={{ marginTop: theme.gridUnit }} />
+        <Icons.CaretDown
+          iconColor={theme.colors.grayscale.base}
+          css={{ marginTop: theme.gridUnit * 0.5 }}
+        />
       </div>
     </Dropdown>
   );