[superset] branch delete-tabs-with-scoped-filter updated: fix: safe removal of tab with filters still scoped to a non-existing chart

[rusackas]

This is an automated email from the ASF dual-hosted git repository.

rusackas pushed a commit to branch delete-tabs-with-scoped-filter
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/delete-tabs-with-scoped-filter 
by this push:
     new 5f4998d  fix: safe removal of tab with filters still scoped to a 
non-existing chart
5f4998d is described below

commit 5f4998dda448d912d53eb60e76f08f32c2ef6d48
Author: Evan Rusackas <e...@preset.io>
AuthorDate: Mon Jul 12 21:12:37 2021 -0600

    fix: safe removal of tab with filters still scoped to a non-existing chart
---
 superset-frontend/src/dashboard/util/activeAllDashboardFilters.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/superset-frontend/src/dashboard/util/activeAllDashboardFilters.ts 
b/superset-frontend/src/dashboard/util/activeAllDashboardFilters.ts
index 2243c25..7b9dc10 100644
--- a/superset-frontend/src/dashboard/util/activeAllDashboardFilters.ts
+++ b/superset-frontend/src/dashboard/util/activeAllDashboardFilters.ts
@@ -104,7 +104,7 @@ export const getAllActiveFilters = ({
       };
     // Iterate over all roots to find all affected charts
     scope.rootPath.forEach((layoutItemId: string | number) => {
-      layout[layoutItemId].children.forEach((child: string) => {
+      layout[layoutItemId]?.children?.forEach((child: string) => {
         // Need exclude from affected charts, charts that located in scope 
`excluded`
         findAffectedCharts({
           child,