This is an automated email from the ASF dual-hosted git repository.
beto pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/master by this push:
new 42a1061 fix: small fixes for Makefile (#15670)
42a1061 is described below
commit 42a1061bfa077ff9dffb088746ee3644caf6d44a
Author: Beto Dealmeida <[email protected]>
AuthorDate: Tue Jul 13 15:45:23 2021 -0700
fix: small fixes for Makefile (#15670)
---
Makefile | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/Makefile b/Makefile
index a51b96f..5de06f0 100644
--- a/Makefile
+++ b/Makefile
@@ -15,6 +15,9 @@
# limitations under the License.
#
+# Python version installed; we need 3.8 or 3.7
+PYTHON=`command -v python3.8 || command -v python3.7`
+
.PHONY: install superset venv pre-commit
install: superset pre-commit
@@ -59,8 +62,9 @@ update-js:
venv:
# Create a virtual environment and activate it (recommended)
- python3 -m venv venv # setup a python3 virtualenv
- source venv/bin/activate
+ if ! [ -x "${PYTHON}" ]; then echo "You need Python 3.7 or 3.8
installed"; exit 1; fi
+ test -d venv || ${PYTHON} -m venv venv # setup a python3 virtualenv
+ . venv/bin/activate
pre-commit:
# setup pre commit dependencies
