[superset] branch master updated: fix(dashboard): Filters panel height (#15661)

[diegopucci]

This is an automated email from the ASF dual-hosted git repository.

diegopucci pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/master by this push:
     new a1793f3  fix(dashboard): Filters panel height (#15661)
a1793f3 is described below

commit a1793f304e2638fe3b74fb34ec8c43d95a671202
Author: Geido <60598000+ge...@users.noreply.github.com>
AuthorDate: Wed Jul 14 16:06:17 2021 +0200

    fix(dashboard): Filters panel height (#15661)
    
    * Fix container height
    
    * Add min height vh
    
    * Remove offset when standalone
    
    * Clean up
---
 .../src/dashboard/components/DashboardBuilder/DashboardBuilder.tsx | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git 
a/superset-frontend/src/dashboard/components/DashboardBuilder/DashboardBuilder.tsx
 
b/superset-frontend/src/dashboard/components/DashboardBuilder/DashboardBuilder.tsx
index 2d9ee81..f706bc7 100644
--- 
a/superset-frontend/src/dashboard/components/DashboardBuilder/DashboardBuilder.tsx
+++ 
b/superset-frontend/src/dashboard/components/DashboardBuilder/DashboardBuilder.tsx
@@ -177,10 +177,9 @@ const DashboardBuilder: FC<DashboardBuilderProps> = () => {
     rootChildId !== DASHBOARD_GRID_ID
       ? dashboardLayout[rootChildId]
       : undefined;
-
+  const isStandalone = getUrlParam(URL_PARAMS.standalone);
   const hideDashboardHeader =
-    getUrlParam(URL_PARAMS.standalone) ===
-    DashboardStandaloneMode.HIDE_NAV_AND_TITLE;
+    isStandalone === DashboardStandaloneMode.HIDE_NAV_AND_TITLE;
 
   const barTopOffset =
     (hideDashboardHeader ? 0 : HEADER_HEIGHT) +
@@ -207,7 +206,7 @@ const DashboardBuilder: FC<DashboardBuilderProps> = () => {
 
   const offset =
     FILTER_BAR_HEADER_HEIGHT +
-    (isSticky ? 0 : MAIN_HEADER_HEIGHT) +
+    (isSticky || isStandalone ? 0 : MAIN_HEADER_HEIGHT) +
     (filterSetEnabled ? FILTER_BAR_TABS_HEIGHT : 0);
 
   const filterBarHeight = `calc(100vh - ${offset}px)`;