This is an automated email from the ASF dual-hosted git repository.
kgabryje pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/master by this push:
new 9ff2531 fix(dashboard): Add resize handles to right and bottom of
component (#15778)
9ff2531 is described below
commit 9ff2531cd04696365b0200ab8f979d1f955781f9
Author: Kamil Gabryjelski <[email protected]>
AuthorDate: Tue Jul 20 11:23:37 2021 +0200
fix(dashboard): Add resize handles to right and bottom of component (#15778)
* fix(dashboard): Add resize handles to right and bottom of component
* Fix test
---
.../cypress/integration/dashboard/markdown.test.ts | 2 +-
superset-frontend/src/dashboard/util/resizableConfig.ts | 10 ++++++----
2 files changed, 7 insertions(+), 5 deletions(-)
diff --git
a/superset-frontend/cypress-base/cypress/integration/dashboard/markdown.test.ts
b/superset-frontend/cypress-base/cypress/integration/dashboard/markdown.test.ts
index dfde7bf..3f69c9f 100644
---
a/superset-frontend/cypress-base/cypress/integration/dashboard/markdown.test.ts
+++
b/superset-frontend/cypress-base/cypress/integration/dashboard/markdown.test.ts
@@ -70,7 +70,7 @@ describe('Dashboard edit markdown', () => {
.type('Test resize');
resize(
- '[data-test="dashboard-markdown-editor"] .resizable-container span div',
+ '[data-test="dashboard-markdown-editor"] .resizable-container span
div:last-child',
).to(500, 600);
cy.get('[data-test="dashboard-markdown-editor"]').contains('Test resize');
diff --git a/superset-frontend/src/dashboard/util/resizableConfig.ts
b/superset-frontend/src/dashboard/util/resizableConfig.ts
index 50bca08..e6d24b4 100644
--- a/superset-frontend/src/dashboard/util/resizableConfig.ts
+++ b/superset-frontend/src/dashboard/util/resizableConfig.ts
@@ -19,8 +19,8 @@
// config for a ResizableContainer
const adjustableWidthAndHeight = {
top: false,
- right: false,
- bottom: false,
+ right: true,
+ bottom: true,
left: false,
topRight: false,
bottomRight: true,
@@ -30,19 +30,21 @@ const adjustableWidthAndHeight = {
const adjustableWidth = {
...adjustableWidthAndHeight,
- right: true,
bottomRight: false,
+ bottom: false,
};
const adjustableHeight = {
...adjustableWidthAndHeight,
- bottom: true,
bottomRight: false,
+ right: false,
};
const notAdjustable = {
...adjustableWidthAndHeight,
bottomRight: false,
+ bottom: false,
+ right: false,
};
export default {