This is an automated email from the ASF dual-hosted git repository. suddjian pushed a commit to branch all-charts-category-alone in repository https://gitbox.apache.org/repos/asf/superset.git
commit 52d03757ffaf722304ffda932762eff19c27b58b Author: David Aaron Suddjian <[email protected]> AuthorDate: Mon Jul 26 17:07:03 2021 -0700 move all charts selector outside of Collapse --- .../controls/VizTypeControl/VizTypeGallery.tsx | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/superset-frontend/src/explore/components/controls/VizTypeControl/VizTypeGallery.tsx b/superset-frontend/src/explore/components/controls/VizTypeControl/VizTypeGallery.tsx index fd64af2..3ade52b 100644 --- a/superset-frontend/src/explore/components/controls/VizTypeControl/VizTypeGallery.tsx +++ b/superset-frontend/src/explore/components/controls/VizTypeControl/VizTypeGallery.tsx @@ -595,11 +595,6 @@ export default function VizTypeGallery(props: VizTypeGalleryProps) { icon: <Icons.Tags />, selectors: RECOMMENDED_TAGS, }, - ALL: { - title: t('All'), - icon: <Icons.Ballot />, - selectors: [ALL_CHARTS], - }, CATEGORY: { title: t('Category'), icon: <Icons.Category />, @@ -623,6 +618,19 @@ export default function VizTypeGallery(props: VizTypeGalleryProps) { return ( <VizPickerLayout className={className}> <LeftPane> + <Selector + css={({ gridUnit }) => + // adjust style for not being inside a collapse + css` + margin: ${gridUnit * 2}px; + margin-bottom: 0; + ` + } + selector={ALL_CHARTS} + icon={<Icons.Ballot />} + isSelected={!isActivelySearching && ALL_CHARTS === activeSelector} + onClick={clickSelector} + /> <Collapse expandIconPosition="right" ghost
