This is an automated email from the ASF dual-hosted git repository.

yongjiezhao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 80c39da  fix: can't drop column when name overlap (#16482)
80c39da is described below

commit 80c39daa85c9be9e66a2e3cf2c9e2a8e5a74a8d6
Author: Yongjie Zhao <[email protected]>
AuthorDate: Wed Sep 1 06:52:10 2021 +0100

    fix: can't drop column when name overlap (#16482)
---
 .../components/controls/DndColumnSelectControl/utils/optionSelector.ts  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git 
a/superset-frontend/src/explore/components/controls/DndColumnSelectControl/utils/optionSelector.ts
 
b/superset-frontend/src/explore/components/controls/DndColumnSelectControl/utils/optionSelector.ts
index 6000d57..4d0d76a 100644
--- 
a/superset-frontend/src/explore/components/controls/DndColumnSelectControl/utils/optionSelector.ts
+++ 
b/superset-frontend/src/explore/components/controls/DndColumnSelectControl/utils/optionSelector.ts
@@ -64,7 +64,7 @@ export class OptionSelector {
   }
 
   has(value: string): boolean {
-    return !!this.getValues()?.includes(value);
+    return ensureIsArray(this.getValues()).includes(value);
   }
 
   getValues(): string[] | string | undefined {

Reply via email to