This is an automated email from the ASF dual-hosted git repository. hugh pushed a commit to branch hugh/fix-explore in repository https://gitbox.apache.org/repos/asf/superset.git
commit e8179f19b89aa438f83ae03398c0b0301b46d8ac Author: hughhhh <[email protected]> AuthorDate: Thu Sep 23 14:26:24 2021 -0400 remove unneeded checks for explore button --- .../src/SqlLab/components/ExploreResultsButton.jsx | 3 --- .../src/SqlLab/components/ResultSet.tsx | 20 +++++++++----------- 2 files changed, 9 insertions(+), 14 deletions(-) diff --git a/superset-frontend/src/SqlLab/components/ExploreResultsButton.jsx b/superset-frontend/src/SqlLab/components/ExploreResultsButton.jsx index 1c94c8b..11a150d 100644 --- a/superset-frontend/src/SqlLab/components/ExploreResultsButton.jsx +++ b/superset-frontend/src/SqlLab/components/ExploreResultsButton.jsx @@ -152,14 +152,11 @@ class ExploreResultsButton extends React.PureComponent { } render() { - const allowsSubquery = - this.props.database && this.props.database.allows_subquery; return ( <> <Button buttonSize="small" onClick={this.props.onClick} - disabled={!allowsSubquery} tooltip={t('Explore the result set in the data exploration view')} > <InfoTooltipWithTrigger diff --git a/superset-frontend/src/SqlLab/components/ResultSet.tsx b/superset-frontend/src/SqlLab/components/ResultSet.tsx index 4f1c788..56eb9e0 100644 --- a/superset-frontend/src/SqlLab/components/ResultSet.tsx +++ b/superset-frontend/src/SqlLab/components/ResultSet.tsx @@ -487,17 +487,15 @@ export default class ResultSet extends React.PureComponent< onChangeAutoComplete={this.handleOnChangeAutoComplete} /> <ResultSetButtons> - {this.props.visualize && - this.props.database && - this.props.database.allows_virtual_table_explore && ( - <ExploreResultsButton - // @ts-ignore Redux types are difficult to work with, ignoring for now - query={this.props.query} - database={this.props.database} - actions={this.props.actions} - onClick={this.handleExploreBtnClick} - /> - )} + {this.props.visualize && this.props.database && ( + <ExploreResultsButton + // @ts-ignore Redux types are difficult to work with, ignoring for now + query={this.props.query} + database={this.props.database} + actions={this.props.actions} + onClick={this.handleExploreBtnClick} + /> + )} {this.props.csv && ( <Button buttonSize="small"
