This is an automated email from the ASF dual-hosted git repository.

hugh pushed a commit to branch hugh/ds-owners
in repository https://gitbox.apache.org/repos/asf/superset.git

commit 24a75286948de28d0745b160cd408404209c5bda
Author: hughhhh <[email protected]>
AuthorDate: Fri Oct 1 11:52:40 2021 -0700

    add owners to the request for updating a dataset
---
 .../src/SqlLab/components/ResultSet.tsx            | 35 +++++++++++++++++++---
 1 file changed, 31 insertions(+), 4 deletions(-)

diff --git a/superset-frontend/src/SqlLab/components/ResultSet.tsx 
b/superset-frontend/src/SqlLab/components/ResultSet.tsx
index 87f08d9..2855e38 100644
--- a/superset-frontend/src/SqlLab/components/ResultSet.tsx
+++ b/superset-frontend/src/SqlLab/components/ResultSet.tsx
@@ -69,9 +69,17 @@ enum LIMITING_FACTOR {
 
 const LOADING_STYLES: CSSProperties = { position: 'relative', minHeight: 100 };
 
+interface Owner {
+  first_name: string;
+  last_name: string;
+  id: number;
+  username: string;
+}
+
 interface DatasetOptionAutocomplete {
   value: string;
   datasetId: number;
+  owner: Owner;
 }
 
 interface ResultSetProps {
@@ -143,12 +151,14 @@ const updateDataset = async (
   sql: string,
   columns: Array<Record<string, any>>,
   overrideColumns: boolean,
+  owners: Array<Record<string, any>>,
 ) => {
   const endpoint = 
`api/v1/dataset/${datasetId}?override_columns=${overrideColumns}`;
   const headers = { 'Content-Type': 'application/json' };
   const body = JSON.stringify({
     sql,
     columns,
+    owners,
   });
 
   const data: JsonResponse = await SupersetClient.put({
@@ -265,11 +275,13 @@ export default class ResultSet extends 
React.PureComponent<
     const { sql, results } = this.props.query;
     const { datasetToOverwrite } = this.state;
 
+    console.log(datasetToOverwrite);
     await updateDataset(
       datasetToOverwrite.datasetId,
       sql,
       results.selected_columns.map(d => ({ column_name: d.name })),
       true,
+      datasetToOverwrite.owners.map((o: Owner) => o.id),
     );
 
     this.setState({
@@ -349,6 +361,7 @@ export default class ResultSet extends React.PureComponent<
     _data: string,
     option: Record<string, any>,
   ) => {
+    console.log(option);
     this.setState({ datasetToOverwrite: option });
   };
 
@@ -405,10 +418,24 @@ export default class ResultSet extends 
React.PureComponent<
         endpoint: '/api/v1/dataset',
       })(`q=${queryParams}`);
 
-      return response.result.map((r: { table_name: string; id: number }) => ({
-        value: r.table_name,
-        datasetId: r.id,
-      }));
+      return response.result.map(
+        (r: {
+          table_name: string;
+          id: number;
+          owners: [
+            {
+              first_name: string;
+              id: number;
+              last_name: string;
+              username: string;
+            },
+          ];
+        }) => ({
+          value: r.table_name,
+          datasetId: r.id,
+          owners: r.owners,
+        }),
+      );
     }
 
     return null;

Reply via email to