This is an automated email from the ASF dual-hosted git repository. hugh pushed a commit to branch hugh/ds-owners in repository https://gitbox.apache.org/repos/asf/superset.git
commit 77c7a153642d03489249a3901d6cc83961b554f5 Author: hughhhh <[email protected]> AuthorDate: Fri Oct 1 11:52:40 2021 -0700 add owners to the request for updating a dataset --- .../src/SqlLab/components/ResultSet.tsx | 33 +++++++++++++++++++--- 1 file changed, 29 insertions(+), 4 deletions(-) diff --git a/superset-frontend/src/SqlLab/components/ResultSet.tsx b/superset-frontend/src/SqlLab/components/ResultSet.tsx index 87f08d9..e5f0885 100644 --- a/superset-frontend/src/SqlLab/components/ResultSet.tsx +++ b/superset-frontend/src/SqlLab/components/ResultSet.tsx @@ -69,9 +69,17 @@ enum LIMITING_FACTOR { const LOADING_STYLES: CSSProperties = { position: 'relative', minHeight: 100 }; +interface Owner { + first_name: string; + last_name: string; + id: number; + username: string; +} + interface DatasetOptionAutocomplete { value: string; datasetId: number; + owner: Owner; } interface ResultSetProps { @@ -142,6 +150,7 @@ const updateDataset = async ( datasetId: number, sql: string, columns: Array<Record<string, any>>, + owners: Array<Owner>, overrideColumns: boolean, ) => { const endpoint = `api/v1/dataset/${datasetId}?override_columns=${overrideColumns}`; @@ -149,6 +158,7 @@ const updateDataset = async ( const body = JSON.stringify({ sql, columns, + owners, }); const data: JsonResponse = await SupersetClient.put({ @@ -269,6 +279,7 @@ export default class ResultSet extends React.PureComponent< datasetToOverwrite.datasetId, sql, results.selected_columns.map(d => ({ column_name: d.name })), + datasetToOverwrite.owners.map((o: Owner) => o.id), true, ); @@ -405,10 +416,24 @@ export default class ResultSet extends React.PureComponent< endpoint: '/api/v1/dataset', })(`q=${queryParams}`); - return response.result.map((r: { table_name: string; id: number }) => ({ - value: r.table_name, - datasetId: r.id, - })); + return response.result.map( + (r: { + table_name: string; + id: number; + owners: [ + { + first_name: string; + id: number; + last_name: string; + username: string; + }, + ]; + }) => ({ + value: r.table_name, + datasetId: r.id, + owners: r.owners, + }), + ); } return null;
