This is an automated email from the ASF dual-hosted git repository. lilykuang pushed a commit to branch embedded-get-guest-user-from-request in repository https://gitbox.apache.org/repos/asf/superset.git
commit 259a2609e3755a416a7bf6a1daf0a328b986a637 Author: Lily Kuang <[email protected]> AuthorDate: Tue Feb 8 16:59:41 2022 -0800 check embedded feature flag in request loader --- superset/security/manager.py | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/superset/security/manager.py b/superset/security/manager.py index 5ca81b2..7f09070 100644 --- a/superset/security/manager.py +++ b/superset/security/manager.py @@ -235,13 +235,15 @@ class SupersetSecurityManager( # pylint: disable=too-many-public-methods guest_user_cls = GuestUser def create_login_manager(self, app: Flask) -> LoginManager: - # pylint: disable=import-outside-toplevel + lm = super().create_login_manager(app) + lm.request_loader(self.request_loader) + return lm + + def request_loader(self, request: Request): from superset.extensions import feature_flag_manager - lm = super().create_login_manager(app) if feature_flag_manager.is_feature_enabled("EMBEDDED_SUPERSET"): - lm.request_loader(self.get_guest_user_from_request) - return lm + return self.get_guest_user_from_request(request) def get_schema_perm( # pylint: disable=no-self-use self, database: Union["Database", str], schema: Optional[str] = None
