This is an automated email from the ASF dual-hosted git repository.
dpgaspar pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/master by this push:
new af91a13 chore: remove PUBLIC_ROLE_LIKE_GAMMA deprecated config key
(#19274)
af91a13 is described below
commit af91a136701401ab52e68fa5946d618f0d78e530
Author: Daniel Vaz Gaspar <[email protected]>
AuthorDate: Mon Mar 21 14:57:38 2022 +0000
chore: remove PUBLIC_ROLE_LIKE_GAMMA deprecated config key (#19274)
---
UPDATING.md | 1 +
superset/security/manager.py | 6 ------
superset/views/core.py | 2 +-
3 files changed, 2 insertions(+), 7 deletions(-)
diff --git a/UPDATING.md b/UPDATING.md
index 64e2276..f9ffadf 100644
--- a/UPDATING.md
+++ b/UPDATING.md
@@ -29,6 +29,7 @@ assists people when migrating to a new version.
### Breaking Changes
+- [19274](https://github.com/apache/superset/pull/19274): The
`PUBLIC_ROLE_LIKE_GAMMA` config key has been removed, set `PUBLIC_ROLE_LIKE` =
"Gamma" to have the same functionality.
- [19273](https://github.com/apache/superset/pull/19273): The
`SUPERSET_CELERY_WORKERS` and `SUPERSET_WORKERS` config keys has been removed.
Configure celery directly using `CELERY_CONFIG` on Superset
- [19231](https://github.com/apache/superset/pull/19231): The
`ENABLE_REACT_CRUD_VIEWS` feature flag has been removed (permanently enabled).
Any deployments which had set this flag to false will need to verify that the
React views support their use case.
- [17556](https://github.com/apache/superset/pull/17556): Bumps mysqlclient
from v1 to v2
diff --git a/superset/security/manager.py b/superset/security/manager.py
index eb068c8..275c77a 100644
--- a/superset/security/manager.py
+++ b/superset/security/manager.py
@@ -726,12 +726,6 @@ class SupersetSecurityManager( # pylint:
disable=too-many-public-methods
self.auth_role_public,
merge=True,
)
- if current_app.config.get("PUBLIC_ROLE_LIKE_GAMMA", False):
- logger.warning(
- "The config `PUBLIC_ROLE_LIKE_GAMMA` is deprecated and will be
removed "
- "in Superset 1.0. Please use `PUBLIC_ROLE_LIKE` instead."
- )
- self.copy_role("Gamma", self.auth_role_public, merge=True)
self.create_missing_perms()
diff --git a/superset/views/core.py b/superset/views/core.py
index 50a5656..5959584 100755
--- a/superset/views/core.py
+++ b/superset/views/core.py
@@ -2792,7 +2792,7 @@ class Superset(BaseSupersetView): # pylint:
disable=too-many-public-methods
def welcome(self) -> FlaskResponse:
"""Personalized welcome page"""
if not g.user or not g.user.get_id():
- if conf.get("PUBLIC_ROLE_LIKE_GAMMA", False) or
conf["PUBLIC_ROLE_LIKE"]:
+ if conf["PUBLIC_ROLE_LIKE"]:
return self.render_template("superset/public_welcome.html")
return redirect(appbuilder.get_url_for_login)
