This is an automated email from the ASF dual-hosted git repository.

villebro pushed a commit to branch 1.5
in repository https://gitbox.apache.org/repos/asf/superset.git

commit 28aa69628faa3e96e51a9939a0b0890c09f64eeb
Author: Kamil Gabryjelski <[email protected]>
AuthorDate: Fri Apr 15 14:56:34 2022 +0200

    chore: Clean redundant dependency from useMemo dep array (#19732)
    
    (cherry picked from commit b7759e6fd138aff83cc80eea23069268ecc717d9)
---
 .../components/controls/DndColumnSelectControl/DndColumnSelect.tsx   | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git 
a/superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndColumnSelect.tsx
 
b/superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndColumnSelect.tsx
index 529d4c7c78..e7b25908cf 100644
--- 
a/superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndColumnSelect.tsx
+++ 
b/superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndColumnSelect.tsx
@@ -126,10 +126,7 @@ export function DndColumnSelect(props: 
DndColumnSelectProps) {
     [onChange, optionSelector],
   );
 
-  const popoverOptions = useMemo(
-    () => Object.values(options),
-    [optionSelector.values, options],
-  );
+  const popoverOptions = useMemo(() => Object.values(options), [options]);
 
   const valuesRenderer = useCallback(
     () =>

Reply via email to