This is an automated email from the ASF dual-hosted git repository.

hugh pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/master by this push:
     new b6c11f2b97 fix: Alpha are unable to perform a second modification to a 
Dataset when in Explore (#20296)
b6c11f2b97 is described below

commit b6c11f2b971abd45281dafa0ac0b105e9d3ba6db
Author: Hugh A. Miles II <[email protected]>
AuthorDate: Wed Jun 8 16:24:36 2022 +0200

    fix: Alpha are unable to perform a second modification to a Dataset when in 
Explore (#20296)
    
    * handle payload coming back from save
    
    * address concerns
---
 .../src/explore/components/controls/DatasourceControl/index.jsx    | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git 
a/superset-frontend/src/explore/components/controls/DatasourceControl/index.jsx 
b/superset-frontend/src/explore/components/controls/DatasourceControl/index.jsx
index 3d6ea2fdd2..f3d4f8aabe 100644
--- 
a/superset-frontend/src/explore/components/controls/DatasourceControl/index.jsx
+++ 
b/superset-frontend/src/explore/components/controls/DatasourceControl/index.jsx
@@ -198,9 +198,10 @@ class DatasourceControl extends React.PureComponent {
 
     const isSqlSupported = datasource.type === 'table';
     const { user } = this.props;
-    const allowEdit =
-      datasource.owners.map(o => o.id).includes(user.userId) ||
-      isUserAdmin(user);
+    const allowEdit = datasource.owners
+      .map(o => o.id || o.value)
+      .includes(user.userId);
+    isUserAdmin(user);
 
     const editText = t('Edit dataset');
 

Reply via email to