This is an automated email from the ASF dual-hosted git repository.

johnbodley pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/master by this push:
     new c3fdd52697 fix(VERSIONED_EXPORTS): Ensure dashboards and charts adher 
to the VERSIONED_EXPORTS feature flag (#20368)
c3fdd52697 is described below

commit c3fdd526977318107685e9b9b28540f2eb89227d
Author: John Bodley <[email protected]>
AuthorDate: Mon Jun 13 18:39:15 2022 -0700

    fix(VERSIONED_EXPORTS): Ensure dashboards and charts adher to the 
VERSIONED_EXPORTS feature flag (#20368)
    
    Co-authored-by: John Bodley <[email protected]>
---
 superset-frontend/src/views/CRUD/dashboard/DashboardList.tsx  | 3 ++-
 superset-frontend/src/views/CRUD/data/dataset/DatasetList.tsx | 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/superset-frontend/src/views/CRUD/dashboard/DashboardList.tsx 
b/superset-frontend/src/views/CRUD/dashboard/DashboardList.tsx
index a00ceefbc8..7dbb30159d 100644
--- a/superset-frontend/src/views/CRUD/dashboard/DashboardList.tsx
+++ b/superset-frontend/src/views/CRUD/dashboard/DashboardList.tsx
@@ -153,7 +153,8 @@ function DashboardList(props: DashboardListProps) {
   const canCreate = hasPerm('can_write');
   const canEdit = hasPerm('can_write');
   const canDelete = hasPerm('can_write');
-  const canExport = hasPerm('can_export');
+  const canExport =
+    hasPerm('can_export') && isFeatureEnabled(FeatureFlag.VERSIONED_EXPORT);
 
   const initialSort = [{ id: 'changed_on_delta_humanized', desc: true }];
 
diff --git a/superset-frontend/src/views/CRUD/data/dataset/DatasetList.tsx 
b/superset-frontend/src/views/CRUD/data/dataset/DatasetList.tsx
index 7d6373b935..80428a9a13 100644
--- a/superset-frontend/src/views/CRUD/data/dataset/DatasetList.tsx
+++ b/superset-frontend/src/views/CRUD/data/dataset/DatasetList.tsx
@@ -174,7 +174,8 @@ const DatasetList: FunctionComponent<DatasetListProps> = ({
   const canEdit = hasPerm('can_write');
   const canDelete = hasPerm('can_write');
   const canCreate = hasPerm('can_write');
-  const canExport = hasPerm('can_export');
+  const canExport =
+    hasPerm('can_export') && isFeatureEnabled(FeatureFlag.VERSIONED_EXPORT);
 
   const initialSort = SORT_BY;
 

Reply via email to