This is an automated email from the ASF dual-hosted git repository.

stephenlyz pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/master by this push:
     new b32288fddf fix(bar-chart-v2): remove marker from bar chart V2 (#20409)
b32288fddf is described below

commit b32288fddfc077d941452245a4e8002335746ba4
Author: Stephen Liu <[email protected]>
AuthorDate: Fri Jun 17 10:52:26 2022 +0800

    fix(bar-chart-v2): remove marker from bar chart V2 (#20409)
---
 .../src/Timeseries/Regular/Bar/controlPanel.tsx    | 34 ----------------------
 1 file changed, 34 deletions(-)

diff --git 
a/superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Regular/Bar/controlPanel.tsx
 
b/superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Regular/Bar/controlPanel.tsx
index 2080fceef6..1992f4a456 100644
--- 
a/superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Regular/Bar/controlPanel.tsx
+++ 
b/superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Regular/Bar/controlPanel.tsx
@@ -45,8 +45,6 @@ import {
 const {
   contributionMode,
   logAxis,
-  markerEnabled,
-  markerSize,
   minorSplitLine,
   rowLimit,
   truncateYAxis,
@@ -341,38 +339,6 @@ const config: ControlPanelConfig = {
       controlSetRows: [
         ['color_scheme'],
         ...showValueSection,
-        [
-          {
-            name: 'markerEnabled',
-            config: {
-              type: 'CheckboxControl',
-              label: t('Marker'),
-              renderTrigger: true,
-              default: markerEnabled,
-              description: t(
-                'Draw a marker on data points. Only applicable for line 
types.',
-              ),
-            },
-          },
-        ],
-        [
-          {
-            name: 'markerSize',
-            config: {
-              type: 'SliderControl',
-              label: t('Marker Size'),
-              renderTrigger: true,
-              min: 0,
-              max: 20,
-              default: markerSize,
-              description: t(
-                'Size of marker. Also applies to forecast observations.',
-              ),
-              visibility: ({ controls }: ControlPanelsContainerProps) =>
-                Boolean(controls?.markerEnabled?.value),
-            },
-          },
-        ],
         [
           {
             name: 'zoomable',

Reply via email to