This is an automated email from the ASF dual-hosted git repository.

rusackas pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/master by this push:
     new b99482dfb1 Try making skipped Cypress test less flaky and un-skip. 
(#20568)
b99482dfb1 is described below

commit b99482dfb1ed831a08e3382f1563109042f37ea9
Author: Cody Leff <[email protected]>
AuthorDate: Thu Jun 30 16:30:32 2022 -0600

    Try making skipped Cypress test less flaky and un-skip. (#20568)
---
 .../cypress/integration/explore/control.test.ts            | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git 
a/superset-frontend/cypress-base/cypress/integration/explore/control.test.ts 
b/superset-frontend/cypress-base/cypress/integration/explore/control.test.ts
index 95bdd514bf..55721500ac 100644
--- a/superset-frontend/cypress-base/cypress/integration/explore/control.test.ts
+++ b/superset-frontend/cypress-base/cypress/integration/explore/control.test.ts
@@ -127,10 +127,16 @@ describe('Test datatable', () => {
     cy.get('[data-test="row-count-label"]').contains('26 rows');
     cy.get('.ant-empty-description').should('not.exist');
   });
-  it.skip('Datapane loads view samples', () => {
-    cy.contains('Samples').click();
-    cy.get('[data-test="row-count-label"]').contains('1k rows');
-    cy.get('.ant-empty-description').should('not.exist');
+  it('Datapane loads view samples', () => {
+    cy.intercept('/api/v1/dataset/*/samples?force=false').as('Samples');
+    cy.contains('Samples')
+      .click()
+      .then(() => {
+        cy.wait('@Samples');
+        cy.get('.ant-tabs-tab-active').contains('Samples');
+        cy.get('[data-test="row-count-label"]').contains('1k rows');
+        cy.get('.ant-empty-description').should('not.exist');
+      });
   });
 });
 

Reply via email to