This is an automated email from the ASF dual-hosted git repository.
yongjiezhao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/master by this push:
new effa7d9f58 fix(dashboard): Native filter on the dashboard with
multiple tabs is displayed as out of scope (#20693)
effa7d9f58 is described below
commit effa7d9f5822c8b837877b23d4866d6d30de6267
Author: Diego Medina <[email protected]>
AuthorDate: Wed Jul 13 05:03:23 2022 -0300
fix(dashboard): Native filter on the dashboard with multiple tabs is
displayed as out of scope (#20693)
---
superset-frontend/src/dashboard/containers/DashboardPage.tsx | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/superset-frontend/src/dashboard/containers/DashboardPage.tsx
b/superset-frontend/src/dashboard/containers/DashboardPage.tsx
index ef3b4893e3..27e17e0f51 100644
--- a/superset-frontend/src/dashboard/containers/DashboardPage.tsx
+++ b/superset-frontend/src/dashboard/containers/DashboardPage.tsx
@@ -186,7 +186,9 @@ export const DashboardPage: FC<PageProps> = ({ idOrSlug }:
PageProps) => {
const isOldRison = getUrlParam(URL_PARAMS.nativeFilters);
let dataMask = nativeFilterKeyValue || {};
- let activeTabs: string[] | undefined = [];
+ // activeTabs is initialized with undefined so that it doesn't override
+ // the currently stored value when hydrating
+ let activeTabs: string[] | undefined;
if (permalinkKey) {
const permalinkValue = await getPermalinkValue(permalinkKey);
if (permalinkValue) {