This is an automated email from the ASF dual-hosted git repository.
dpgaspar pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/master by this push:
new e6b0141c67 fix(releases): docker build on M1 npm run build fails
(#20700)
e6b0141c67 is described below
commit e6b0141c6769ed9d51dc9674014a559ef6f63a44
Author: Daniel Vaz Gaspar <[email protected]>
AuthorDate: Wed Jul 13 23:53:31 2022 +0100
fix(releases): docker build on M1 npm run build fails (#20700)
---
RELEASING/Dockerfile.from_local_tarball | 2 +-
RELEASING/Dockerfile.from_svn_tarball | 2 +-
RELEASING/test_run_tarball.sh | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/RELEASING/Dockerfile.from_local_tarball
b/RELEASING/Dockerfile.from_local_tarball
index 3cd030609b..ff7eb56536 100644
--- a/RELEASING/Dockerfile.from_local_tarball
+++ b/RELEASING/Dockerfile.from_local_tarball
@@ -30,7 +30,7 @@ RUN apt-get install -y apt-transport-https apt-utils
# Install superset dependencies
#
https://superset.apache.org/docs/installation/installing-superset-from-scratch
RUN apt-get install -y build-essential libssl-dev \
- libffi-dev python3-dev libsasl2-dev libldap2-dev libxi-dev
+ libffi-dev python3-dev libsasl2-dev libldap2-dev libxi-dev chromium
# Install nodejs for custom build
# https://nodejs.org/en/download/package-manager/
diff --git a/RELEASING/Dockerfile.from_svn_tarball
b/RELEASING/Dockerfile.from_svn_tarball
index 482ab474a5..b88481f40d 100644
--- a/RELEASING/Dockerfile.from_svn_tarball
+++ b/RELEASING/Dockerfile.from_svn_tarball
@@ -30,7 +30,7 @@ RUN apt-get install -y apt-transport-https apt-utils
# Install superset dependencies
#
https://superset.apache.org/docs/installation/installing-superset-from-scratch
RUN apt-get install -y build-essential libssl-dev \
- libffi-dev python3-dev libsasl2-dev libldap2-dev libxi-dev
+ libffi-dev python3-dev libsasl2-dev libldap2-dev libxi-dev chromium
# Install nodejs for custom build
# https://nodejs.org/en/download/package-manager/
diff --git a/RELEASING/test_run_tarball.sh b/RELEASING/test_run_tarball.sh
index 112adc8cff..d4c8a9c706 100755
--- a/RELEASING/test_run_tarball.sh
+++ b/RELEASING/test_run_tarball.sh
@@ -26,7 +26,7 @@ if [ -z "${SUPERSET_SVN_DEV_PATH}" ]; then
SUPERSET_SVN_DEV_PATH="$HOME/svn/superset_dev"
fi
-if [ ${1} == "local" ]; then
+if [[ -n ${1} ]] && [[ ${1} == "local" ]]; then
SUPERSET_RELEASE_RC=apache-superset-"${SUPERSET_VERSION_RC}"
SUPERSET_RELEASE_RC_TARBALL="${SUPERSET_RELEASE_RC}"-source.tar.gz
SUPERSET_TARBALL_PATH="${SUPERSET_SVN_DEV_PATH}"/${SUPERSET_VERSION_RC}/${SUPERSET_RELEASE_RC_TARBALL}