This is an automated email from the ASF dual-hosted git repository.
rusackas pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/master by this push:
new d925b0c883 fix(heatmap): add detail descriptions for heatmap
'normalize across' (#20566)
d925b0c883 is described below
commit d925b0c8835fb1773b80298a3de1bdc368c88850
Author: Stephen Liu <[email protected]>
AuthorDate: Wed Jul 20 23:39:22 2022 +0800
fix(heatmap): add detail descriptions for heatmap 'normalize across'
(#20566)
* fix(heatmap): change 'Normalize Across' to 'Color Based On' and add some
label
* Update
superset-frontend/plugins/legacy-plugin-chart-heatmap/src/controlPanel.tsx
Co-authored-by: Evan Rusackas <[email protected]>
* Update
superset-frontend/plugins/legacy-plugin-chart-heatmap/src/controlPanel.tsx
Co-authored-by: Evan Rusackas <[email protected]>
* Update
superset-frontend/plugins/legacy-plugin-chart-heatmap/src/controlPanel.tsx
Co-authored-by: Evan Rusackas <[email protected]>
* Update
superset-frontend/plugins/legacy-plugin-chart-heatmap/src/controlPanel.tsx
Co-authored-by: Evan Rusackas <[email protected]>
* fix lint
Co-authored-by: Evan Rusackas <[email protected]>
---
.../src/{controlPanel.ts => controlPanel.tsx} | 22 ++++++++++++++++++----
1 file changed, 18 insertions(+), 4 deletions(-)
diff --git
a/superset-frontend/plugins/legacy-plugin-chart-heatmap/src/controlPanel.ts
b/superset-frontend/plugins/legacy-plugin-chart-heatmap/src/controlPanel.tsx
similarity index 92%
rename from
superset-frontend/plugins/legacy-plugin-chart-heatmap/src/controlPanel.ts
rename to
superset-frontend/plugins/legacy-plugin-chart-heatmap/src/controlPanel.tsx
index f4528d23b5..3ba3548fc7 100644
--- a/superset-frontend/plugins/legacy-plugin-chart-heatmap/src/controlPanel.ts
+++ b/superset-frontend/plugins/legacy-plugin-chart-heatmap/src/controlPanel.tsx
@@ -16,6 +16,7 @@
* specific language governing permissions and limitations
* under the License.
*/
+import React from 'react';
import {
FeatureFlag,
isFeatureEnabled,
@@ -170,10 +171,23 @@ const config: ControlPanelConfig = {
['y', 'y'],
],
default: 'heatmap',
- description: t(
- 'Color will be rendered based on a ratio ' +
- 'of the cell against the sum of across this ' +
- 'criteria',
+ description: (
+ <>
+ <div>
+ {t(
+ 'Color will be shaded based the normalized (0% to 100%)
value of a given cell against the other cells in the selected range: ',
+ )}
+ </div>
+ <ul>
+ <li>{t('x: values are normalized within each column')}</li>
+ <li>{t('y: values are normalized within each row')}</li>
+ <li>
+ {t(
+ 'heatmap: values are normalized across the entire
heatmap',
+ )}
+ </li>
+ </ul>
+ </>
),
},
},
