This is an automated email from the ASF dual-hosted git repository. lyndsi pushed a commit to branch lyndsi/sql-lab-new-explore-button-functionality-and-move-save-dataset-to-split-save-button in repository https://gitbox.apache.org/repos/asf/superset.git
commit 1411016bddffcba31f0d50ff79cb02024b3ade9a Author: lyndsiWilliams <[email protected]> AuthorDate: Mon Jul 11 14:06:41 2022 -0500 Fix broken tests --- superset-frontend/src/SqlLab/components/SaveQuery/SaveQuery.test.jsx | 2 +- superset-frontend/src/SqlLab/reducers/sqlLab.test.js | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/superset-frontend/src/SqlLab/components/SaveQuery/SaveQuery.test.jsx b/superset-frontend/src/SqlLab/components/SaveQuery/SaveQuery.test.jsx index da9403171d..667615d0bd 100644 --- a/superset-frontend/src/SqlLab/components/SaveQuery/SaveQuery.test.jsx +++ b/superset-frontend/src/SqlLab/components/SaveQuery/SaveQuery.test.jsx @@ -153,7 +153,7 @@ describe('SavedQuery', () => { const closeBtn = screen.getByRole('button', { name: /close/i }); const saveDatasetHeader = screen.getByText(/save or overwrite dataset/i); const saveRadio = screen.getByRole('radio', { - name: /save as new undefined/i, + name: /save as new untitled dataset/i, }); const saveLabel = screen.getByText(/save as new/i); const saveTextbox = screen.getByRole('textbox'); diff --git a/superset-frontend/src/SqlLab/reducers/sqlLab.test.js b/superset-frontend/src/SqlLab/reducers/sqlLab.test.js index c986fc5ac0..4c92e13247 100644 --- a/superset-frontend/src/SqlLab/reducers/sqlLab.test.js +++ b/superset-frontend/src/SqlLab/reducers/sqlLab.test.js @@ -96,14 +96,14 @@ describe('sqlLabReducer', () => { expect(newState.queryEditors[1].autorun).toBe(true); }); it('should not fail while setting title', () => { - const title = 'a new title'; + const title = 'Untitled Query 1'; const action = { type: actions.QUERY_EDITOR_SET_TITLE, queryEditor: qe, title, }; newState = sqlLabReducer(newState, action); - expect(newState.queryEditors[1].title).toBe(title); + expect(newState.queryEditors[0].name).toBe(title); }); it('should not fail while setting Sql', () => { const sql = 'SELECT nothing from dev_null';
