This is an automated email from the ASF dual-hosted git repository.
kgabryje pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/master by this push:
new 8005b7f8c7 fix(plugin-chart-table): Upgrade old color formats (#21101)
8005b7f8c7 is described below
commit 8005b7f8c77fa96e0ff32958830ba307db74abff
Author: Kamil Gabryjelski <[email protected]>
AuthorDate: Tue Aug 16 22:05:53 2022 +0200
fix(plugin-chart-table): Upgrade old color formats (#21101)
* fix(plugin-chart-table): Upgrade old color formats
* Bug fix
* add comments
---
...665d_fix_table_chart_conditional_formatting_.py | 82 ++++++++++++++++++++++
1 file changed, 82 insertions(+)
diff --git
a/superset/migrations/versions/2022-08-16_15-23_6d3c6f9d665d_fix_table_chart_conditional_formatting_.py
b/superset/migrations/versions/2022-08-16_15-23_6d3c6f9d665d_fix_table_chart_conditional_formatting_.py
new file mode 100644
index 0000000000..30caf7efa1
--- /dev/null
+++
b/superset/migrations/versions/2022-08-16_15-23_6d3c6f9d665d_fix_table_chart_conditional_formatting_.py
@@ -0,0 +1,82 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+"""fix_table_chart_conditional_formatting_colors
+
+Revision ID: 6d3c6f9d665d
+Revises: ffa79af61a56
+Create Date: 2022-08-16 15:23:42.860038
+
+"""
+import json
+
+from alembic import op
+from sqlalchemy import Column, Integer, String, Text
+from sqlalchemy.ext.declarative import declarative_base
+
+from superset import db
+
+# revision identifiers, used by Alembic.
+revision = "6d3c6f9d665d"
+down_revision = "ffa79af61a56"
+
+Base = declarative_base()
+
+
+class Slice(Base):
+ __tablename__ = "slices"
+ id = Column(Integer, primary_key=True)
+ viz_type = Column(String(250))
+ params = Column(Text)
+
+
+def upgrade():
+ bind = op.get_bind()
+ session = db.Session(bind=bind)
+
+ for slc in session.query(Slice).filter(Slice.viz_type == "table"):
+ params = json.loads(slc.params)
+ conditional_formatting = params.get("conditional_formatting", [])
+ if conditional_formatting:
+ new_conditional_formatting = []
+ for formatter in conditional_formatting:
+ color_scheme = formatter.get("colorScheme")
+ new_color_scheme = None
+ if color_scheme == "rgb(0,255,0)":
+ # supersetTheme.colors.success.light1
+ new_color_scheme = "#ACE1C4"
+ elif color_scheme == "rgb(255,255,0)":
+ # supersetTheme.colors.alert.light1
+ new_color_scheme = "#FDE380"
+ elif color_scheme == "rgb(255,0,0)":
+ # supersetTheme.colors.error.light1
+ new_color_scheme = "#EFA1AA"
+ if new_color_scheme:
+ new_conditional_formatting.append(
+ {**formatter, "colorScheme": new_color_scheme}
+ )
+ else:
+ new_conditional_formatting.append(formatter)
+ params["conditional_formatting"] = new_conditional_formatting
+ slc.params = json.dumps(params)
+ session.merge(slc)
+ session.commit()
+ session.close()
+
+
+# it fixes a bug, downgrading isn't really needed here
+def downgrade():
+ pass
