This is an automated email from the ASF dual-hosted git repository. lyndsi pushed a commit to branch lyndsi-fix-refetch-async-queries in repository https://gitbox.apache.org/repos/asf/superset.git
commit c72108d58dff248a0deb0fef25407efdc5006cbc Merge: a78c62f06f c248ee56e4 Author: lyndsiWilliams <[email protected]> AuthorDate: Tue Oct 4 16:13:39 2022 -0500 Merge branch 'master' of https://github.com/apache/superset RESOURCES/FEATURE_FLAGS.md | 21 +++++++ RESOURCES/INTHEWILD.md | 1 + requirements/base.txt | 24 +------- setup.py | 6 +- .../src/addSlice/AddSliceContainer.tsx | 13 ++-- .../components/Range/RangeFilterPlugin.test.tsx | 26 +++++--- .../filters/components/Range/RangeFilterPlugin.tsx | 4 +- .../src/profile/components/CreatedContent.tsx | 41 ++++++++---- superset-frontend/src/types/bootstrapTypes.ts | 10 +++ .../views/CRUD/data/dataset/AddDatasetModal.tsx | 14 +++-- superset/charts/api.py | 4 +- superset/charts/filters.py | 16 +++++ superset/dashboards/filters.py | 2 +- superset/databases/api.py | 4 ++ superset/databases/commands/validate.py | 7 +-- superset/db_engine_specs/base.py | 7 ++- superset/db_engine_specs/bigquery.py | 5 +- superset/db_engine_specs/gsheets.py | 7 ++- superset/db_engine_specs/snowflake.py | 4 +- ...-09-19_14-42_b92d69a6643c_rename_csv_to_file.py | 2 +- superset/models/core.py | 17 ++--- superset/reports/commands/exceptions.py | 18 +++++- superset/reports/commands/execute.py | 24 ++++---- superset/reports/notifications/slack.py | 4 +- superset/tasks/slack_util.py | 6 +- superset/views/core.py | 5 ++ tests/integration_tests/charts/api_tests.py | 40 ++++++++++++ tests/integration_tests/dashboards/api_tests.py | 38 ++++++++---- .../db_engine_specs/base_engine_spec_tests.py | 72 ++++++++++++---------- tests/integration_tests/model_tests.py | 4 +- tests/integration_tests/reports/commands_tests.py | 5 +- tests/unit_tests/databases/api_test.py | 6 ++ tests/unit_tests/databases/schema_tests.py | 1 - tests/unit_tests/db_engine_specs/test_gsheets.py | 52 +++++++++------- 34 files changed, 341 insertions(+), 169 deletions(-) diff --cc superset/databases/commands/validate.py index dc72fd57c3,a8956257fa..853e813cc6 --- a/superset/databases/commands/validate.py +++ b/superset/databases/commands/validate.py @@@ -39,18 -37,9 +39,18 @@@ from superset.models.core import Databa BYPASS_VALIDATION_ENGINES = {"bigquery"} +def get_engine_parameters(properties: Dict[str, Any]) -> Dict[str, Any]: + try: + if properties.get("extra"): + return json.loads(properties["extra"]).get("engine_params", {}) + return {} + except: + raise DatabaseExtraJSONValidationError("Unable to parse extra_json data") + + class ValidateDatabaseParametersCommand(BaseCommand): - def __init__(self, parameters: Dict[str, Any]): - self._properties = parameters.copy() + def __init__(self, properties: Dict[str, Any]): + self._properties = properties.copy() self._model: Optional[Database] = None def run(self) -> None:
