This is an automated email from the ASF dual-hosted git repository. diegopucci pushed a commit to branch feat/d2d-charts-crud-filter-col in repository https://gitbox.apache.org/repos/asf/superset.git
commit 515018e807069a22f8afc26b52300e19c6ee5e00 Author: geido <[email protected]> AuthorDate: Mon Oct 10 17:01:23 2022 +0300 Enhance E2E tests --- .../cypress/integration/chart_list/filter.test.ts | 14 ++++++++++++++ .../cypress/integration/chart_list/list.test.ts | 9 +++++---- 2 files changed, 19 insertions(+), 4 deletions(-) diff --git a/superset-frontend/cypress-base/cypress/integration/chart_list/filter.test.ts b/superset-frontend/cypress-base/cypress/integration/chart_list/filter.test.ts index eff4151079..9ba7a4a29e 100644 --- a/superset-frontend/cypress-base/cypress/integration/chart_list/filter.test.ts +++ b/superset-frontend/cypress-base/cypress/integration/chart_list/filter.test.ts @@ -62,6 +62,13 @@ describe('Charts filters', () => { setFilter('Dataset', 'unicode_test'); cy.getBySel('styled-card').should('have.length', 1); }); + + it('should filter by dashboards correctly', () => { + setFilter('Dashboards', 'Unicode Test'); + cy.getBySel('styled-card').should('have.length', 1); + setFilter('Dashboards', 'Tabbed Dashboard'); + cy.getBySel('styled-card').should('have.length', 9); + }); }); describe('list-view', () => { @@ -96,5 +103,12 @@ describe('Charts filters', () => { setFilter('Dataset', 'unicode_test'); cy.getBySel('table-row').should('have.length', 1); }); + + it('should filter by dashboards correctly', () => { + setFilter('Dashboards', 'Unicode Test'); + cy.getBySel('table-row').should('have.length', 1); + setFilter('Dashboards', 'Tabbed Dashboard'); + cy.getBySel('table-row').should('have.length', 9); + }); }); }); diff --git a/superset-frontend/cypress-base/cypress/integration/chart_list/list.test.ts b/superset-frontend/cypress-base/cypress/integration/chart_list/list.test.ts index e3837445d9..6981ead73a 100644 --- a/superset-frontend/cypress-base/cypress/integration/chart_list/list.test.ts +++ b/superset-frontend/cypress-base/cypress/integration/chart_list/list.test.ts @@ -59,10 +59,11 @@ describe('Charts list', () => { cy.getBySel('sort-header').eq(1).contains('Chart'); cy.getBySel('sort-header').eq(2).contains('Visualization type'); cy.getBySel('sort-header').eq(3).contains('Dataset'); - cy.getBySel('sort-header').eq(4).contains('Modified by'); - cy.getBySel('sort-header').eq(5).contains('Last modified'); - cy.getBySel('sort-header').eq(6).contains('Created by'); - cy.getBySel('sort-header').eq(7).contains('Actions'); + cy.getBySel('sort-header').eq(4).contains('Dashboards added to'); + cy.getBySel('sort-header').eq(5).contains('Modified by'); + cy.getBySel('sort-header').eq(6).contains('Last modified'); + cy.getBySel('sort-header').eq(7).contains('Created by'); + cy.getBySel('sort-header').eq(8).contains('Actions'); }); it('should sort correctly in list mode', () => {
