This is an automated email from the ASF dual-hosted git repository.

diegopucci pushed a commit to branch fix/cypress-flaky
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/fix/cypress-flaky by this push:
     new 098279d427 Fix lower frequency flaky tests
098279d427 is described below

commit 098279d4271b0d9d5deeb43d6c29e38d7d4db68e
Author: geido <[email protected]>
AuthorDate: Wed Oct 26 17:21:41 2022 +0300

    Fix lower frequency flaky tests
---
 .../cypress/integration/dashboard/editmode.test.ts         |  1 +
 .../cypress/integration/dashboard/nativeFilters.test.ts    | 14 +++++++-------
 .../cypress/integration/explore/control.test.ts            |  1 +
 3 files changed, 9 insertions(+), 7 deletions(-)

diff --git 
a/superset-frontend/cypress-base/cypress/integration/dashboard/editmode.test.ts 
b/superset-frontend/cypress-base/cypress/integration/dashboard/editmode.test.ts
index f4cc44acc8..794dc9744f 100644
--- 
a/superset-frontend/cypress-base/cypress/integration/dashboard/editmode.test.ts
+++ 
b/superset-frontend/cypress-base/cypress/integration/dashboard/editmode.test.ts
@@ -62,6 +62,7 @@ function dragComponent(
     cy.getBySel('dashboard-charts-filter-search-input').type(component);
     cy.wait('@filtering');
   }
+  cy.wait(500);
   drag(`[data-test="${target}"]`, component).to(
     '[data-test="grid-content"] [data-test="dragdroppable-object"]',
   );
diff --git 
a/superset-frontend/cypress-base/cypress/integration/dashboard/nativeFilters.test.ts
 
b/superset-frontend/cypress-base/cypress/integration/dashboard/nativeFilters.test.ts
index 3a86900035..3d9f92962d 100644
--- 
a/superset-frontend/cypress-base/cypress/integration/dashboard/nativeFilters.test.ts
+++ 
b/superset-frontend/cypress-base/cypress/integration/dashboard/nativeFilters.test.ts
@@ -593,13 +593,13 @@ describe('Native filters', () => {
     });
 
     it('User can cancel changes in native filter', () => {
-      visitDashboard();
-      enterNativeFilterEditModal(false);
-      fillNativeFilterForm(
-        testItems.filterType.value,
-        'suffix',
-        testItems.datasetForNativeFilter,
-      );
+      prepareDashboardFilters([
+        { name: 'country_name', column: 'country_name', datasetId: 2 },
+      ]);
+      enterNativeFilterEditModal();
+      cy.getBySel('filters-config-modal__name-input').type('|EDITED', {
+        force: true,
+      });
       cancelNativeFilterSettings();
       enterNativeFilterEditModal();
       cy.get(nativeFilters.filtersList.removeIcon).first().click();
diff --git 
a/superset-frontend/cypress-base/cypress/integration/explore/control.test.ts 
b/superset-frontend/cypress-base/cypress/integration/explore/control.test.ts
index 98bb95f000..28354b256d 100644
--- a/superset-frontend/cypress-base/cypress/integration/explore/control.test.ts
+++ b/superset-frontend/cypress-base/cypress/integration/explore/control.test.ts
@@ -198,6 +198,7 @@ describe('Time range filter', () => {
           cy.get('input[value="now"]');
         });
         cy.get('[data-test=cancel-button]').click();
+        cy.wait(500);
         cy.get('.ant-popover').should('not.be.visible');
       });
   });

Reply via email to