This is an automated email from the ASF dual-hosted git repository.

lyndsi pushed a commit to branch lyndsi/tables-with-preexisting-datasets
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to 
refs/heads/lyndsi/tables-with-preexisting-datasets by this push:
     new b58e6894b1 Set view dataset button to open in new tab
b58e6894b1 is described below

commit b58e6894b115cfeccbef8a7953ab1b210ac8bc99
Author: lyndsiWilliams <[email protected]>
AuthorDate: Tue Nov 15 18:50:13 2022 -0600

    Set view dataset button to open in new tab
---
 .../CRUD/data/dataset/AddDataset/DatasetPanel/DatasetPanel.tsx      | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git 
a/superset-frontend/src/views/CRUD/data/dataset/AddDataset/DatasetPanel/DatasetPanel.tsx
 
b/superset-frontend/src/views/CRUD/data/dataset/AddDataset/DatasetPanel/DatasetPanel.tsx
index 5571e4b773..daa19cb83b 100644
--- 
a/superset-frontend/src/views/CRUD/data/dataset/AddDataset/DatasetPanel/DatasetPanel.tsx
+++ 
b/superset-frontend/src/views/CRUD/data/dataset/AddDataset/DatasetPanel/DatasetPanel.tsx
@@ -208,7 +208,11 @@ const renderExistingDatasetAlert = (linkedDataset: any) => 
(
         <span
           role="button"
           onClick={() => {
-            window.location.href = linkedDataset.explore_url;
+            window.open(
+              linkedDataset.explore_url,
+              '_blank',
+              'noreferer noopener popup=false',
+            );
           }}
           tabIndex={0}
           className="view-dataset-button"

Reply via email to