This is an automated email from the ASF dual-hosted git repository. diegopucci pushed a commit to branch fix/flaky-e2e-test-high-medium in repository https://gitbox.apache.org/repos/asf/superset.git
commit 64bf7f3106a3d0b4b896dcab2f507bb5b1ebecfc Author: geido <[email protected]> AuthorDate: Thu Nov 17 17:51:23 2022 +0200 Minor improvements --- .../cypress-base/cypress/integration/dashboard/drilltodetail.test.ts | 2 +- .../cypress-base/cypress/integration/dashboard/nativeFilters.test.ts | 2 ++ .../cypress-base/cypress/integration/dashboard/utils.ts | 4 ++-- superset-frontend/cypress-base/cypress/integration/explore/utils.ts | 5 ++++- 4 files changed, 9 insertions(+), 4 deletions(-) diff --git a/superset-frontend/cypress-base/cypress/integration/dashboard/drilltodetail.test.ts b/superset-frontend/cypress-base/cypress/integration/dashboard/drilltodetail.test.ts index caf938b33c..0950810156 100644 --- a/superset-frontend/cypress-base/cypress/integration/dashboard/drilltodetail.test.ts +++ b/superset-frontend/cypress-base/cypress/integration/dashboard/drilltodetail.test.ts @@ -65,7 +65,7 @@ function openModalFromChartContext(targetMenuItem: string) { .first() .click(); } - + cy.getBySel('metadata-bar').should('be.visible'); cy.wait('@samples'); } diff --git a/superset-frontend/cypress-base/cypress/integration/dashboard/nativeFilters.test.ts b/superset-frontend/cypress-base/cypress/integration/dashboard/nativeFilters.test.ts index 3d9f92962d..afcd5b2f60 100644 --- a/superset-frontend/cypress-base/cypress/integration/dashboard/nativeFilters.test.ts +++ b/superset-frontend/cypress-base/cypress/integration/dashboard/nativeFilters.test.ts @@ -457,6 +457,7 @@ describe('Native filters', () => { search.split('').slice(1, search.length).join(''); cy.location().then(loc => { + cy.url().should('contain', 'native_filters_key'); const queryParams = qs.parse(removeFirstChar(loc.search)); filterKey = queryParams.native_filters_key as string; expect(typeof filterKey).eq('string'); @@ -465,6 +466,7 @@ describe('Native filters', () => { addCountryNameFilter(); saveNativeFilterSettings([SAMPLE_CHART]); cy.location().then(loc => { + cy.url().should('contain', 'native_filters_key'); const queryParams = qs.parse(removeFirstChar(loc.search)); const newfilterKey = queryParams.native_filters_key; expect(newfilterKey).eq(filterKey); diff --git a/superset-frontend/cypress-base/cypress/integration/dashboard/utils.ts b/superset-frontend/cypress-base/cypress/integration/dashboard/utils.ts index 5acbcd6bfb..6434dc9c4c 100644 --- a/superset-frontend/cypress-base/cypress/integration/dashboard/utils.ts +++ b/superset-frontend/cypress-base/cypress/integration/dashboard/utils.ts @@ -350,8 +350,8 @@ export function cancelNativeFilterSettings() { .should('be.visible') .click(); cy.get(nativeFilters.modal.alertXUnsavedFilters) - .should('have.text', 'There are unsaved changes.') - .should('be.visible'); + .should('be.visible') + .should('have.text', 'There are unsaved changes.'); cy.get(nativeFilters.modal.footer) .find(nativeFilters.modal.yesCancelButton) .contains('cancel') diff --git a/superset-frontend/cypress-base/cypress/integration/explore/utils.ts b/superset-frontend/cypress-base/cypress/integration/explore/utils.ts index 245d9d3b09..914f3a9143 100644 --- a/superset-frontend/cypress-base/cypress/integration/explore/utils.ts +++ b/superset-frontend/cypress-base/cypress/integration/explore/utils.ts @@ -17,7 +17,10 @@ * under the License. */ -import { interceptGet as interceptDashboardGet, interceptDashboardasync } from '../dashboard/utils'; +import { + interceptGet as interceptDashboardGet, + interceptDashboardasync, +} from '../dashboard/utils'; export function interceptFiltering() { cy.intercept('GET', `/api/v1/chart/?q=*`).as('filtering');
