This is an automated email from the ASF dual-hosted git repository. aafghahi pushed a commit to branch arash.afghahi/sc-61350/db-connect-error-msg-is-not-show-on-basic in repository https://gitbox.apache.org/repos/asf/superset.git
commit 049f7f2dc93142daa4654d7482c501e03b18ead3 Author: AAfghahi <[email protected]> AuthorDate: Tue Nov 22 16:16:04 2022 -0500 error messages --- .../CRUD/data/database/DatabaseModal/index.tsx | 23 ++++++++++------------ 1 file changed, 10 insertions(+), 13 deletions(-) diff --git a/superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx b/superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx index 003f9d64be..f46ca88260 100644 --- a/superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx +++ b/superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx @@ -1164,15 +1164,16 @@ const DatabaseModal: FunctionComponent<DatabaseModalProps> = ({ ] : []; } - if (alertErrors.length) { return ( - <ErrorMessageWithStackTrace - title={t('Database Creation Error')} - description={alertErrors[0]} - subtitle={validationErrors?.description} - copyText={validationErrors?.description} - /> + <ErrorAlertContainer> + <ErrorMessageWithStackTrace + title={t('Database Creation Error')} + description={alertErrors[0]} + subtitle={validationErrors?.description} + copyText={validationErrors?.description} + /> + </ErrorAlertContainer> ); } return <></>; @@ -1479,6 +1480,7 @@ const DatabaseModal: FunctionComponent<DatabaseModalProps> = ({ /> </StyledAlertMargin> )} + {showDBError && errorAlert()} </Tabs.TabPane> <Tabs.TabPane tab={<span>{t('Advanced')}</span>} key="2"> <ExtraOptions @@ -1512,9 +1514,6 @@ const DatabaseModal: FunctionComponent<DatabaseModalProps> = ({ onChange(ActionType.extraEditorChange, payload); }} /> - {showDBError && ( - <ErrorAlertContainer>{errorAlert()}</ErrorAlertContainer> - )} </Tabs.TabPane> </TabsStyled> </Modal> @@ -1676,9 +1675,7 @@ const DatabaseModal: FunctionComponent<DatabaseModalProps> = ({ )} </div> {/* Step 2 */} - {showDBError && ( - <ErrorAlertContainer>{errorAlert()}</ErrorAlertContainer> - )} + {showDBError && errorAlert()} </> ))} </>
