This is an automated email from the ASF dual-hosted git repository. hugh pushed a commit to branch test-ssh-tunnel-1 in repository https://gitbox.apache.org/repos/asf/superset.git
commit f4ab29d5b5b8d35cd7f8e4eb9f6390ce7c94d783 Author: Antonio Rivero <[email protected]> AuthorDate: Tue Nov 29 17:00:33 2022 -0300 SSH Tunnel: - Make server_address, server_port and username required fields for our SSHTunnel schema - Update the tests so we can consider new message with required fields --- superset/databases/schemas.py | 6 +++--- tests/integration_tests/databases/api_tests.py | 9 ++++++++- 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/superset/databases/schemas.py b/superset/databases/schemas.py index 8cf6f01597..b6dfb5553d 100644 --- a/superset/databases/schemas.py +++ b/superset/databases/schemas.py @@ -369,9 +369,9 @@ class DatabaseSSHTunnel(Schema): id = fields.Integer() database_id = fields.Integer() - server_address = fields.String() - server_port = fields.Integer() - username = fields.String() + server_address = fields.String(required=True) + server_port = fields.Integer(required=True) + username = fields.String(required=True) # Basic Authentication password = fields.String(required=False) diff --git a/tests/integration_tests/databases/api_tests.py b/tests/integration_tests/databases/api_tests.py index 4eb1f9ebd4..588de0554a 100644 --- a/tests/integration_tests/databases/api_tests.py +++ b/tests/integration_tests/databases/api_tests.py @@ -507,7 +507,14 @@ class TestDatabaseApi(SupersetTestCase): "ssh_tunnel": ssh_tunnel_properties, } fail_message = { - "message": {"ssh_tunnel": {"server_address_failure": ["Unknown field."]}} + "message": { + "ssh_tunnel": { + "server_address_failure": ["Unknown field."], + "server_address": ["Missing data for required field."], + "server_port": ["Missing data for required field."], + "username": ["Missing data for required field."], + } + } } uri = "api/v1/database/"
