This is an automated email from the ASF dual-hosted git repository.
villebro pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/master by this push:
new d4b9c18271 fix(sql-editor): Fix run stop button color to improve
usability (#23892)
d4b9c18271 is described below
commit d4b9c1827148126aa17b1ea29c4e0790394c5edc
Author: curious86 <[email protected]>
AuthorDate: Wed May 3 02:06:25 2023 -0700
fix(sql-editor): Fix run stop button color to improve usability (#23892)
Co-authored-by: aadhikari <[email protected]>
---
.../src/SqlLab/components/RunQueryActionButton/index.tsx | 4 +++-
superset-frontend/src/explore/components/RunQueryButton/index.tsx | 2 +-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git
a/superset-frontend/src/SqlLab/components/RunQueryActionButton/index.tsx
b/superset-frontend/src/SqlLab/components/RunQueryActionButton/index.tsx
index 0a2aa99264..f9181188f9 100644
--- a/superset-frontend/src/SqlLab/components/RunQueryActionButton/index.tsx
+++ b/superset-frontend/src/SqlLab/components/RunQueryActionButton/index.tsx
@@ -146,7 +146,9 @@ const RunQueryActionButton = ({
),
trigger: 'click',
}
- : { buttonStyle: 'primary' })}
+ : {
+ buttonStyle: shouldShowStopBtn ? 'warning' : 'primary',
+ })}
>
{buildText(shouldShowStopBtn, selectedText)}
</ButtonComponent>
diff --git a/superset-frontend/src/explore/components/RunQueryButton/index.tsx
b/superset-frontend/src/explore/components/RunQueryButton/index.tsx
index 622cb516f0..f5e3bcfed0 100644
--- a/superset-frontend/src/explore/components/RunQueryButton/index.tsx
+++ b/superset-frontend/src/explore/components/RunQueryButton/index.tsx
@@ -42,7 +42,7 @@ export const RunQueryButton = ({
}: RunQueryButtonProps) =>
loading ? (
<Button onClick={onStop} buttonStyle="warning" disabled={!canStopQuery}>
- <i className="fa fa-stop-circle-o" /> {t('Stop')}
+ <i className="fa fa-stop" /> {t('Stop')}
</Button>
) : (
<Button
