[superset] branch master updated: fix(explore): rendering regression on standalone (#24177)

[johnbodley]

This is an automated email from the ASF dual-hosted git repository.

johnbodley pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 8e45af43e1 fix(explore): rendering regression on standalone (#24177)
8e45af43e1 is described below

commit 8e45af43e11fd3a26e1047cf6b45547bbd4e8eda
Author: JUST.in DO IT <justin.p...@airbnb.com>
AuthorDate: Tue May 23 09:49:04 2023 -0700

    fix(explore): rendering regression on standalone (#24177)
---
 .../src/explore/components/ExploreChartPanel/index.jsx  |  6 +++++-
 .../ExploreViewContainer/ExploreViewContainer.test.tsx  | 17 ++++++++++++++++-
 2 files changed, 21 insertions(+), 2 deletions(-)

diff --git 
a/superset-frontend/src/explore/components/ExploreChartPanel/index.jsx 
b/superset-frontend/src/explore/components/ExploreChartPanel/index.jsx
index 893a10275a..0dee4d076e 100644
--- a/superset-frontend/src/explore/components/ExploreChartPanel/index.jsx
+++ b/superset-frontend/src/explore/components/ExploreChartPanel/index.jsx
@@ -418,7 +418,11 @@ const ExploreChartPanel = ({
     if (!bodyClasses.includes(standaloneClass)) {
       document.body.className += ` ${standaloneClass}`;
     }
-    return standaloneChartBody;
+    return (
+      <div id="app" data-test="standalone-app" ref={resizeObserverRef}>
+        {standaloneChartBody}
+      </div>
+    );
   }
 
   return (
diff --git 
a/superset-frontend/src/explore/components/ExploreViewContainer/ExploreViewContainer.test.tsx
 
b/superset-frontend/src/explore/components/ExploreViewContainer/ExploreViewContainer.test.tsx
index fbfb0c3b1d..1681fdce0d 100644
--- 
a/superset-frontend/src/explore/components/ExploreViewContainer/ExploreViewContainer.test.tsx
+++ 
b/superset-frontend/src/explore/components/ExploreViewContainer/ExploreViewContainer.test.tsx
@@ -97,14 +97,19 @@ fetchMock.get('glob:*/api/v1/explore/form_data*', {});
 fetchMock.get('glob:*/api/v1/chart/favorite_status*', {
   result: [{ value: true }],
 });
+fetchMock.get('glob:*/api/v1/chart/*', {
+  result: {},
+});
 
 const defaultPath = '/explore/';
 const renderWithRouter = ({
   search = '',
   overridePathname,
+  initialState = reduxState,
 }: {
   search?: string;
   overridePathname?: string;
+  initialState?: object;
 } = {}) => {
   const path = overridePathname ?? defaultPath;
   Object.defineProperty(window, 'location', {
@@ -118,7 +123,7 @@ const renderWithRouter = ({
         <ExploreViewContainer />
       </Route>
     </MemoryRouter>,
-    { useRedux: true, initialState: reduxState },
+    { useRedux: true, initialState },
   );
 };
 
@@ -146,6 +151,16 @@ test('generates a new form_data param when none is 
available', async () => {
   replaceState.mockRestore();
 });
 
+test('renders chart in standalone mode', () => {
+  const { queryByTestId } = renderWithRouter({
+    initialState: {
+      ...reduxState,
+      explore: { ...reduxState.explore, standalone: true },
+    },
+  });
+  expect(queryByTestId('standalone-app')).toBeTruthy();
+});
+
 test('generates a different form_data param when one is provided and is 
mounting', async () => {
   const replaceState = jest.spyOn(window.history, 'replaceState');
   await waitFor(() => renderWithRouter({ search: SEARCH }));