This is an automated email from the ASF dual-hosted git repository.

kgabryje pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 2e4d9f2e2a fix: Ensure config is a dict in cross filters scope 
migration (#24661)
2e4d9f2e2a is described below

commit 2e4d9f2e2a137944a1c6b7dbfbb15f931cfc525e
Author: Kamil Gabryjelski <[email protected]>
AuthorDate: Tue Jul 11 17:15:28 2023 +0200

    fix: Ensure config is a dict in cross filters scope migration (#24661)
---
 .../2023-05-11_12-41_4ea966691069_cross_filter_global_scoping.py      | 4 ++++
 1 file changed, 4 insertions(+)

diff --git 
a/superset/migrations/versions/2023-05-11_12-41_4ea966691069_cross_filter_global_scoping.py
 
b/superset/migrations/versions/2023-05-11_12-41_4ea966691069_cross_filter_global_scoping.py
index 0d16acb250..76bcc932fd 100644
--- 
a/superset/migrations/versions/2023-05-11_12-41_4ea966691069_cross_filter_global_scoping.py
+++ 
b/superset/migrations/versions/2023-05-11_12-41_4ea966691069_cross_filter_global_scoping.py
@@ -62,6 +62,8 @@ def upgrade():
             json_metadata = json.loads(dashboard.json_metadata or "{}")
             new_chart_configuration = {}
             for config in json_metadata.get("chart_configuration", 
{}).values():
+                if not isinstance(config, dict):
+                    continue
                 chart_id = int(config.get("id", 0))
                 scope = config.get("crossFilters", {}).get("scope", {})
 
@@ -105,6 +107,8 @@ def downgrade():
             json_metadata = json.loads(dashboard.json_metadata)
             new_chart_configuration = {}
             for config in json_metadata.get("chart_configuration", 
{}).values():
+                if not isinstance(config, dict):
+                    continue
                 chart_id = config.get("id")
                 if chart_id is None:
                     continue

Reply via email to