This is an automated email from the ASF dual-hosted git repository.
lilykuang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/master by this push:
new 16f31f8090 feat(sqllab): extra logging when chart is downloaded
(#25345)
16f31f8090 is described below
commit 16f31f8090b5afed89c0b4ccf42e9dc1852da7ae
Author: Zef Lin <[email protected]>
AuthorDate: Thu Sep 21 09:43:06 2023 -0700
feat(sqllab): extra logging when chart is downloaded (#25345)
---
.../useExploreAdditionalActionsMenu/index.jsx | 42 ++++++++++++++++++++--
superset-frontend/src/logger/LogUtils.ts | 5 +++
2 files changed, 45 insertions(+), 2 deletions(-)
diff --git
a/superset-frontend/src/explore/components/useExploreAdditionalActionsMenu/index.jsx
b/superset-frontend/src/explore/components/useExploreAdditionalActionsMenu/index.jsx
index 2ccbbeb25e..eca77780b1 100644
---
a/superset-frontend/src/explore/components/useExploreAdditionalActionsMenu/index.jsx
+++
b/superset-frontend/src/explore/components/useExploreAdditionalActionsMenu/index.jsx
@@ -17,7 +17,7 @@
* under the License.
*/
import React, { useCallback, useMemo, useState } from 'react';
-import { useSelector } from 'react-redux';
+import { useDispatch, useSelector } from 'react-redux';
import {
css,
isFeatureEnabled,
@@ -36,6 +36,14 @@ import downloadAsImage from 'src/utils/downloadAsImage';
import { getChartPermalink } from 'src/utils/urlUtils';
import copyTextToClipboard from 'src/utils/copy';
import HeaderReportDropDown from
'src/features/reports/ReportModal/HeaderReportDropdown';
+import { logEvent } from 'src/logger/actions';
+import {
+ LOG_ACTIONS_CHART_DOWNLOAD_AS_IMAGE,
+ LOG_ACTIONS_CHART_DOWNLOAD_AS_JSON,
+ LOG_ACTIONS_CHART_DOWNLOAD_AS_CSV,
+ LOG_ACTIONS_CHART_DOWNLOAD_AS_CSV_PIVOTED,
+ LOG_ACTIONS_CHART_DOWNLOAD_AS_XLS,
+} from 'src/logger/LogUtils';
import ViewQueryModal from '../controls/ViewQueryModal';
import EmbedCodeContent from '../EmbedCodeContent';
import DashboardsSubMenu from './DashboardsSubMenu';
@@ -118,6 +126,7 @@ export const useExploreAdditionalActionsMenu = (
) => {
const theme = useTheme();
const { addDangerToast, addSuccessToast } = useToasts();
+ const dispatch = useDispatch();
const [showReportSubMenu, setShowReportSubMenu] = useState(null);
const [isDropdownVisible, setIsDropdownVisible] = useState(false);
const chart = useSelector(
@@ -204,19 +213,42 @@ export const useExploreAdditionalActionsMenu = (
case MENU_KEYS.EXPORT_TO_CSV:
exportCSV();
setIsDropdownVisible(false);
+ dispatch(
+ logEvent(LOG_ACTIONS_CHART_DOWNLOAD_AS_CSV, {
+ chartId: slice?.slice_id,
+ chartName: slice?.slice_name,
+ }),
+ );
break;
case MENU_KEYS.EXPORT_TO_CSV_PIVOTED:
exportCSVPivoted();
setIsDropdownVisible(false);
+ dispatch(
+ logEvent(LOG_ACTIONS_CHART_DOWNLOAD_AS_CSV_PIVOTED, {
+ chartId: slice?.slice_id,
+ chartName: slice?.slice_name,
+ }),
+ );
break;
case MENU_KEYS.EXPORT_TO_JSON:
exportJson();
setIsDropdownVisible(false);
-
+ dispatch(
+ logEvent(LOG_ACTIONS_CHART_DOWNLOAD_AS_JSON, {
+ chartId: slice?.slice_id,
+ chartName: slice?.slice_name,
+ }),
+ );
break;
case MENU_KEYS.EXPORT_TO_XLSX:
exportExcel();
setIsDropdownVisible(false);
+ dispatch(
+ logEvent(LOG_ACTIONS_CHART_DOWNLOAD_AS_XLS, {
+ chartId: slice?.slice_id,
+ chartName: slice?.slice_name,
+ }),
+ );
break;
case MENU_KEYS.DOWNLOAD_AS_IMAGE:
downloadAsImage(
@@ -226,6 +258,12 @@ export const useExploreAdditionalActionsMenu = (
true,
)(domEvent);
setIsDropdownVisible(false);
+ dispatch(
+ logEvent(LOG_ACTIONS_CHART_DOWNLOAD_AS_IMAGE, {
+ chartId: slice?.slice_id,
+ chartName: slice?.slice_name,
+ }),
+ );
break;
case MENU_KEYS.COPY_PERMALINK:
copyLink();
diff --git a/superset-frontend/src/logger/LogUtils.ts
b/superset-frontend/src/logger/LogUtils.ts
index 46864a0357..31fae5b0c4 100644
--- a/superset-frontend/src/logger/LogUtils.ts
+++ b/superset-frontend/src/logger/LogUtils.ts
@@ -52,6 +52,11 @@ export const
LOG_ACTIONS_CONFIRM_OVERWRITE_DASHBOARD_METADATA =
export const LOG_ACTIONS_DASHBOARD_DOWNLOAD_AS_IMAGE =
'dashboard_download_as_image';
export const LOG_ACTIONS_CHART_DOWNLOAD_AS_IMAGE = 'chart_download_as_image';
+export const LOG_ACTIONS_CHART_DOWNLOAD_AS_CSV = 'chart_download_as_csv';
+export const LOG_ACTIONS_CHART_DOWNLOAD_AS_CSV_PIVOTED =
+ 'chart_download_as_csv_pivoted';
+export const LOG_ACTIONS_CHART_DOWNLOAD_AS_XLS = 'chart_download_as_xls';
+export const LOG_ACTIONS_CHART_DOWNLOAD_AS_JSON = 'chart_download_as_json';
export const LOG_ACTIONS_SQLLAB_WARN_LOCAL_STORAGE_USAGE =
'sqllab_warn_local_storage_usage';
export const LOG_ACTIONS_SQLLAB_FETCH_FAILED_QUERY =
